diff --git a/lib/browser/api/web-contents.js b/lib/browser/api/web-contents.js index 095aa1fb3174..a3bccab82336 100644 --- a/lib/browser/api/web-contents.js +++ b/lib/browser/api/web-contents.js @@ -269,12 +269,6 @@ WebContents.prototype.getZoomFactor = function (callback) { }) } -// TODO(zcbenz): Remove the stub in 4.0. -WebContents.prototype.setSize = function () { - console.error('The WebContents.setSize method has been removed, see', - 'https://github.com/electron/electron/issues/14120 for more.') -} - // Add JavaScript wrappers for WebContents class. WebContents.prototype._init = function () { // The navigation controller. diff --git a/lib/renderer/web-view/web-view.js b/lib/renderer/web-view/web-view.js index 29bcbd5e5774..668eb5f0214a 100644 --- a/lib/renderer/web-view/web-view.js +++ b/lib/renderer/web-view/web-view.js @@ -16,13 +16,6 @@ const getNextId = function () { return ++nextId } -// A list of removed attributes from 3.0. -const removedAttributes = [ - 'autoresize', - 'disableguestresize', - 'guestinstance' -] - // Represents the internal state of the WebView node. class WebViewImpl { constructor (webviewNode) { @@ -32,13 +25,6 @@ class WebViewImpl { this.beforeFirstNavigation = true this.hasFocus = false - // Check for removed attributes. - for (const attributeName of removedAttributes) { - if (this.webviewNode.hasAttribute(attributeName)) { - this.reportRemovedAttribute(attributeName) - } - } - // on* Event handlers. this.on = {} @@ -106,11 +92,6 @@ class WebViewImpl { // attribute, if necessary. See BrowserPlugin::UpdateDOMAttribute for more // details. handleWebviewAttributeMutation (attributeName, oldValue, newValue) { - if (removedAttributes.includes(attributeName)) { - this.reportRemovedAttribute(attributeName) - return - } - if (!this.attributes[attributeName] || this.attributes[attributeName].ignoreMutation) { return } @@ -215,12 +196,6 @@ class WebViewImpl { // even documented. this.resizeObserver = new ResizeObserver(this.onElementResize.bind(this)).observe(this.internalElement) } - - // TODO(zcbenz): Remove the warning in 4.0. - reportRemovedAttribute (attributeName) { - console.error(`The "${attributeName}" attribute has been removed from the tag,`, - 'see https://github.com/electron/electron/issues/14120 for more.') - } } // Registers custom element. diff --git a/spec/fixtures/pages/webview-move-to-window.html b/spec/fixtures/pages/webview-move-to-window.html deleted file mode 100644 index fc142225da36..000000000000 --- a/spec/fixtures/pages/webview-move-to-window.html +++ /dev/null @@ -1,17 +0,0 @@ - - - - - diff --git a/spec/fixtures/pages/webview-no-guest-resize.html b/spec/fixtures/pages/webview-no-guest-resize.html deleted file mode 100644 index b05314b6e2b7..000000000000 --- a/spec/fixtures/pages/webview-no-guest-resize.html +++ /dev/null @@ -1,23 +0,0 @@ - - - - - - -