mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Take const references

Browse source
This commit is contained in:
Kevin Sawicki 2017-03-13 10:25:30 -07:00
parent dac6e0ce66
commit 37c9d76cd5
2 changed files with 7 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
atom/browser/ui/cocoa/atom_scrubber_data_source.h
View file

@ -18,8 +18,8 @@
std::vector<mate::PersistentDictionary> items_; std::vector<mate::PersistentDictionary> items_;
} }
- (id)initWithItems:(std::vector<mate::PersistentDictionary>)items; - (id)initWithItems:(const std::vector<mate::PersistentDictionary>&)items;
- (void)setItems:(std::vector<mate::PersistentDictionary>)items; - (void)setItems:(const std::vector<mate::PersistentDictionary>&)items;
@end @end

9
atom/browser/ui/cocoa/atom_scrubber_data_source.mm
View file

@ -13,18 +13,19 @@
static NSString* const TextItemIdentifier = @"scrubber.text.item"; static NSString* const TextItemIdentifier = @"scrubber.text.item";
static NSString* const ImageItemIdentifier = @"scrubber.image.item"; static NSString* const ImageItemIdentifier = @"scrubber.image.item";
- (id)initWithItems:(std::vector<mate::PersistentDictionary>)items { - (id)initWithItems:(const std::vector<mate::PersistentDictionary>&)items {
if ((self = [super init])) { if ((self = [super init])) {
items_ = items; items_ = items;
} }
return self; return self;
} }
- (NSInteger)numberOfItemsForScrubber:(NSScrubber *)theScrubber { - (NSInteger)numberOfItemsForScrubber:(NSScrubber*)theScrubber {
return items_.size(); return items_.size();
} }
- (NSScrubberItemView *)scrubber:(NSScrubber *)scrubber viewForItemAtIndex:(NSInteger)index { - (NSScrubberItemView*)scrubber:(NSScrubber*)scrubber
viewForItemAtIndex:(NSInteger)index {
mate::PersistentDictionary item = items_[index]; mate::PersistentDictionary item = items_[index];
NSScrubberItemView* itemView; NSScrubberItemView* itemView;
@ -48,7 +49,7 @@ static NSString* const ImageItemIdentifier = @"scrubber.image.item";
return itemView; return itemView;
} }
- (void)setItems:(std::vector<mate::PersistentDictionary>)items { - (void)setItems:(const std::vector<mate::PersistentDictionary>&)items {
items_ = items; items_ = items;
} }