Implement 'activiate' event instead of 'activate-with-open-windows'.

This commit is contained in:
Haojian Wu 2015-09-14 18:34:27 -07:00
parent c006c4efa4
commit 377e7ee3a7
7 changed files with 20 additions and 14 deletions

View file

@ -171,8 +171,8 @@ void App::OnActivateWithNoOpenWindows() {
Emit("activate-with-no-open-windows");
}
void App::OnActivateWithOpenWindows() {
Emit("activate-with-open-windows");
void App::OnActivate(bool hasVisibleWindows) {
Emit("activate", hasVisibleWindows);
}
void App::OnWillFinishLaunching() {

View file

@ -42,7 +42,7 @@ class App : public mate::EventEmitter,
void OnOpenFile(bool* prevent_default, const std::string& file_path) override;
void OnOpenURL(const std::string& url) override;
void OnActivateWithNoOpenWindows() override;
void OnActivateWithOpenWindows() override;
void OnActivate(bool hasVisibleWindows) override;
void OnWillFinishLaunching() override;
void OnFinishLaunching() override;
void OnSelectCertificate(

View file

@ -98,8 +98,8 @@ void Browser::ActivateWithNoOpenWindows() {
FOR_EACH_OBSERVER(BrowserObserver, observers_, OnActivateWithNoOpenWindows());
}
void Browser::ActivateWithOpenWindows() {
FOR_EACH_OBSERVER(BrowserObserver, observers_, OnActivateWithOpenWindows());
void Browser::Activate(bool hasVisibleWindows) {
FOR_EACH_OBSERVER(BrowserObserver, observers_, OnActivate(hasVisibleWindows));
}
void Browser::WillFinishLaunching() {

View file

@ -111,8 +111,9 @@ class Browser : public WindowListObserver {
// Tell the application that application is activated with no open windows.
void ActivateWithNoOpenWindows();
// Tell the application that application is activated with open windows.
void ActivateWithOpenWindows();
// Tell the application that application is activated with visible/invisible
// windows.
void Activate(bool hasVisibleWindows);
// Tell the application the loading has been done.
void WillFinishLaunching();

View file

@ -47,9 +47,9 @@ class BrowserObserver {
// dock icon).
virtual void OnActivateWithNoOpenWindows() {}
// The browser is activated with open windows (usually by clicking on the dock
// icon).
virtual void OnActivateWithOpenWindows() {}
// The browser is activated with visible/invisible windows (usually by
// clicking on the dock icon).
virtual void OnActivate(bool hasVisibleWindows) {}
// The browser has finished loading.
virtual void OnWillFinishLaunching() {}

View file

@ -52,8 +52,8 @@
- (BOOL)applicationShouldHandleReopen:(NSApplication*)theApplication
hasVisibleWindows:(BOOL)flag {
atom::Browser* browser = atom::Browser::Get();
browser->Activate(static_cast<bool>(flag));
if (flag) {
browser->ActivateWithOpenWindows();
return YES;
} else {
browser->ActivateWithNoOpenWindows();