mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

Fix failed devtools tests due to fs.statSyncNoException not working (#13584)

Browse source 
* Revert "spec: disable the i18nString test"

This reverts commit 86c79653de.

* update node to fix fs.statSyncNoException
This commit is contained in:
Cheng Zhao 2018-07-09 23:38:48 +09:00 • committed by Charles Kerr
parent 17fc7bb9fd
commit 35b867ff7d
2 changed files with 2 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

3
spec/api-browser-window-spec.js
View file

@ -2819,8 +2819,7 @@ describe('BrowserWindow module', () => {
expect(this.message).to.have.own.property('tabId') expect(this.message).to.have.own.property('tabId')
expect(this.message.tabId).to.equal(w.webContents.id) expect(this.message.tabId).to.equal(w.webContents.id)
}) })
// TODO(zcbena): [Ch66] Enable the tests. it('has "i18nString" with proper contents', function () {
xit('has "i18nString" with proper contents', function () {
expect(this.message).to.have.own.property('i18nString') expect(this.message).to.have.own.property('i18nString')
expect(this.message.i18nString).to.equal('foo - bar (baz)') expect(this.message.i18nString).to.equal('foo - bar (baz)')
}) })

2
vendor/node vendored

@ -1 +1 @@
Subproject commit e61694e449e62e36dfe243d266e6313a0a043d5c Subproject commit a782199c99b5716582791fe8145756fd5bcfde27