mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

fix: revert moving IsClosed() and IsClosable() into NativeWindow::Close() (#47482)

Browse source 
Revert "refactor: move `IsClosed()` and `IsClosable()` tests into `NativeWindow::Close()` (#46888)"

This reverts commit 3faddd5ae2.
This commit is contained in:
Keeley Hammond 2025-06-16 16:41:19 -07:00 • committed by GitHub
commit 3536d4976a
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
8 changed files with 35 additions and 35 deletions
Download patch file Download diff file Expand all files Collapse all files

4
shell/browser/window_list.cc
View file

@ -84,7 +84,7 @@ void WindowList::CloseAllWindows() {
std::ranges::reverse(weak_windows);
#endif
for (const auto& window : weak_windows) {
if (window)
if (window && !window->IsClosed())
window->Close();
}
}
@ -95,7 +95,7 @@ void WindowList::DestroyAllWindows() {
ConvertToWeakPtrVector(GetInstance()->windows_);
for (const auto& window : weak_windows) {
if (window)
if (window && !window->IsClosed())
window->CloseImmediately();
}
}