mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: increase stack size on windows (#27376)

Browse source
This commit is contained in:
Robo 2021-01-20 00:50:05 -08:00 committed by GitHub
parent e4fc47f557
commit 34772292f7
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 13 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
BUILD.gn
View file

@ -1154,6 +1154,19 @@ if (is_mac) {
ldflags += [ "/guard:cf,nolongjmp" ] ldflags += [ "/guard:cf,nolongjmp" ]
} }
if (current_cpu == "x86") {
# Set the initial stack size to 0.5MiB, instead of the 1.5MiB needed by
# Chrome's main thread. This saves significant memory on threads (like
# those in the Windows thread pool, and others) whose stack size we can
# only control through this setting. Because Chrome's main thread needs
# a minimum 1.5 MiB stack, the main thread (in 32-bit builds only) uses
# fibers to switch to a 1.5 MiB stack before running any other code.
ldflags += [ "/STACK:0x80000" ]
} else {
# Increase the initial stack size. The default is 1MB, this is 8MB.
ldflags += [ "/STACK:0x800000" ]
}
# This is to support renaming of electron.exe. node-gyp has hard-coded # This is to support renaming of electron.exe. node-gyp has hard-coded
# executable names which it will recognise as node. This module definition # executable names which it will recognise as node. This module definition
# file claims that the electron executable is in fact named "node.exe", # file claims that the electron executable is in fact named "node.exe",