From 343c42e4ef4a868c37ff941e57649a5867bb620d Mon Sep 17 00:00:00 2001 From: Aleksei Kuzmin Date: Wed, 11 Apr 2018 11:00:59 +0200 Subject: [PATCH] Remove redundant device::PowerSaveBlocker enums. https://chromium-review.googlesource.com/754169 services/device: Fix enum naming in wake_lock.mojom. https://chromium-review.googlesource.com/755884 --- .../api/atom_api_power_save_blocker.cc | 30 +++++++++---------- .../browser/api/atom_api_power_save_blocker.h | 11 ++++--- 2 files changed, 19 insertions(+), 22 deletions(-) diff --git a/atom/browser/api/atom_api_power_save_blocker.cc b/atom/browser/api/atom_api_power_save_blocker.cc index 04ac43d7e1b0..0b06a9f58378 100644 --- a/atom/browser/api/atom_api_power_save_blocker.cc +++ b/atom/browser/api/atom_api_power_save_blocker.cc @@ -15,18 +15,17 @@ namespace mate { template <> -struct Converter { +struct Converter { static bool FromV8(v8::Isolate* isolate, v8::Local val, - device::PowerSaveBlocker::PowerSaveBlockerType* out) { - using device::PowerSaveBlocker; + device::mojom::WakeLockType* out) { std::string type; if (!ConvertFromV8(isolate, val, &type)) return false; if (type == "prevent-app-suspension") - *out = PowerSaveBlocker::kPowerSaveBlockPreventAppSuspension; + *out = device::mojom::WakeLockType::kPreventAppSuspension; else if (type == "prevent-display-sleep") - *out = PowerSaveBlocker::kPowerSaveBlockPreventDisplaySleep; + *out = device::mojom::WakeLockType::kPreventDisplaySleep; else return false; return true; @@ -41,7 +40,7 @@ namespace api { PowerSaveBlocker::PowerSaveBlocker(v8::Isolate* isolate) : current_blocker_type_( - device::PowerSaveBlocker::kPowerSaveBlockPreventAppSuspension) { + device::mojom::WakeLockType::kPreventAppSuspension) { Init(isolate); } @@ -53,26 +52,26 @@ void PowerSaveBlocker::UpdatePowerSaveBlocker() { return; } - // |kPowerSaveBlockPreventAppSuspension| keeps system active, but allows + // |WakeLockType::kPreventAppSuspension| keeps system active, but allows // screen to be turned off. - // |kPowerSaveBlockPreventDisplaySleep| keeps system and screen active, has a - // higher precedence level than |kPowerSaveBlockPreventAppSuspension|. + // |WakeLockType::kPreventDisplaySleep| keeps system and screen active, has a + // higher precedence level than |WakeLockType::kPreventAppSuspension|. // // Only the highest-precedence blocker type takes effect. - device::PowerSaveBlocker::PowerSaveBlockerType new_blocker_type = - device::PowerSaveBlocker::kPowerSaveBlockPreventAppSuspension; + device::mojom::WakeLockType new_blocker_type = + device::mojom::WakeLockType::kPreventAppSuspension; for (const auto& element : power_save_blocker_types_) { if (element.second == - device::PowerSaveBlocker::kPowerSaveBlockPreventDisplaySleep) { + device::mojom::WakeLockType::kPreventDisplaySleep) { new_blocker_type = - device::PowerSaveBlocker::kPowerSaveBlockPreventDisplaySleep; + device::mojom::WakeLockType::kPreventDisplaySleep; break; } } if (!power_save_blocker_ || new_blocker_type != current_blocker_type_) { auto new_blocker = std::make_unique( - new_blocker_type, device::PowerSaveBlocker::kReasonOther, + new_blocker_type, device::mojom::WakeLockReason::kOther, ATOM_PRODUCT_NAME, base::ThreadTaskRunnerHandle::Get(), // This task runner may be used by some device service // implementation bits to interface with dbus client code, which in @@ -85,8 +84,7 @@ void PowerSaveBlocker::UpdatePowerSaveBlocker() { } } -int PowerSaveBlocker::Start( - device::PowerSaveBlocker::PowerSaveBlockerType type) { +int PowerSaveBlocker::Start(device::mojom::WakeLockType type) { static int count = 0; power_save_blocker_types_[count] = type; UpdatePowerSaveBlocker(); diff --git a/atom/browser/api/atom_api_power_save_blocker.h b/atom/browser/api/atom_api_power_save_blocker.h index 70379c690281..d56222db95de 100644 --- a/atom/browser/api/atom_api_power_save_blocker.h +++ b/atom/browser/api/atom_api_power_save_blocker.h @@ -33,19 +33,18 @@ class PowerSaveBlocker : public mate::TrackableObject { private: void UpdatePowerSaveBlocker(); - int Start(device::PowerSaveBlocker::PowerSaveBlockerType type); + int Start(device::mojom::WakeLockType type); bool Stop(int id); bool IsStarted(int id); std::unique_ptr power_save_blocker_; - // Currnet blocker type used by |power_save_blocker_| - device::PowerSaveBlocker::PowerSaveBlockerType current_blocker_type_; + // Current blocker type used by |power_save_blocker_| + device::mojom::WakeLockType current_blocker_type_; // Map from id to the corresponding blocker type for each request. - using PowerSaveBlockerTypeMap = - std::map; - PowerSaveBlockerTypeMap power_save_blocker_types_; + using WakeLockTypeMap = std::map; + WakeLockTypeMap power_save_blocker_types_; DISALLOW_COPY_AND_ASSIGN(PowerSaveBlocker); };