fix: ensure windows respect fullscreenability with different resizability values (#39620)
* fix: ensure child windows respect fullscreenability/resizability when parent is fullscreen * test: add an extra resize test
This commit is contained in:
parent
2affecd4dd
commit
33e66b5cd0
2 changed files with 46 additions and 14 deletions
|
@ -5416,6 +5416,42 @@ describe('BrowserWindow module', () => {
|
|||
expect(w.isFullScreenable()).to.be.true('isFullScreenable');
|
||||
});
|
||||
});
|
||||
|
||||
it('does not open non-fullscreenable child windows in fullscreen if parent is fullscreen', async () => {
|
||||
const w = new BrowserWindow();
|
||||
|
||||
const enterFS = once(w, 'enter-full-screen');
|
||||
w.setFullScreen(true);
|
||||
await enterFS;
|
||||
|
||||
const child = new BrowserWindow({ parent: w, resizable: false, fullscreenable: false });
|
||||
const shown = once(child, 'show');
|
||||
await shown;
|
||||
|
||||
expect(child.resizable).to.be.false('resizable');
|
||||
expect(child.fullScreen).to.be.false('fullscreen');
|
||||
expect(child.fullScreenable).to.be.false('fullscreenable');
|
||||
});
|
||||
|
||||
it('is set correctly with different resizable values', async () => {
|
||||
const w1 = new BrowserWindow({
|
||||
resizable: false,
|
||||
fullscreenable: false
|
||||
});
|
||||
|
||||
const w2 = new BrowserWindow({
|
||||
resizable: true,
|
||||
fullscreenable: false
|
||||
});
|
||||
|
||||
const w3 = new BrowserWindow({
|
||||
fullscreenable: false
|
||||
});
|
||||
|
||||
expect(w1.isFullScreenable()).to.be.false('isFullScreenable');
|
||||
expect(w2.isFullScreenable()).to.be.false('isFullScreenable');
|
||||
expect(w3.isFullScreenable()).to.be.false('isFullScreenable');
|
||||
});
|
||||
});
|
||||
|
||||
ifdescribe(process.platform === 'darwin')('isHiddenInMissionControl state', () => {
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue