From d294637e9c3ecf9ef7d669eda7b0b11ff4c1fe94 Mon Sep 17 00:00:00 2001 From: Charles Kerr Date: Thu, 16 Aug 2018 11:45:04 -0700 Subject: [PATCH 1/4] chore: enable jumbo builds in GN release configuration --- build/args/release.gn | 1 + 1 file changed, 1 insertion(+) diff --git a/build/args/release.gn b/build/args/release.gn index 23b15367a7e..c51778164de 100644 --- a/build/args/release.gn +++ b/build/args/release.gn @@ -2,6 +2,7 @@ import("all.gn") is_component_build = false is_official_build = true is_component_ffmpeg = true +use_jumbo_build = true # TODO(nornagon): linking non-CFI code (nodejs) with CFI code fails at runtime. # Once we can build nodejs with CFI flags matching Electron's, remove this. From 3e0d961684afcb1a8a2c24088683b43c6b01e7d6 Mon Sep 17 00:00:00 2001 From: Charles Kerr Date: Thu, 16 Aug 2018 11:46:35 -0700 Subject: [PATCH 2/4] chore: alphabetize config list --- build/args/release.gn | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/build/args/release.gn b/build/args/release.gn index c51778164de..48d586ca27f 100644 --- a/build/args/release.gn +++ b/build/args/release.gn @@ -1,7 +1,7 @@ import("all.gn") is_component_build = false -is_official_build = true is_component_ffmpeg = true +is_official_build = true use_jumbo_build = true # TODO(nornagon): linking non-CFI code (nodejs) with CFI code fails at runtime. From 575b6df844f729e5617f92e48a3abb8f17e6f93a Mon Sep 17 00:00:00 2001 From: Charles Kerr Date: Thu, 16 Aug 2018 13:41:47 -0700 Subject: [PATCH 3/4] chore: promote 'is_jumbo_build=true' to all.gn --- build/args/all.gn | 1 + build/args/release.gn | 1 - 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/build/args/all.gn b/build/args/all.gn index 41e11de62c7..8f27ad1130e 100644 --- a/build/args/all.gn +++ b/build/args/all.gn @@ -1,5 +1,6 @@ is_electron_build = true is_electron_gn_build = true +use_jumbo_build = true root_extra_deps = [ "//electron" ] v8_promise_internal_field_count = 1 diff --git a/build/args/release.gn b/build/args/release.gn index 48d586ca27f..0804548965b 100644 --- a/build/args/release.gn +++ b/build/args/release.gn @@ -2,7 +2,6 @@ import("all.gn") is_component_build = false is_component_ffmpeg = true is_official_build = true -use_jumbo_build = true # TODO(nornagon): linking non-CFI code (nodejs) with CFI code fails at runtime. # Once we can build nodejs with CFI flags matching Electron's, remove this. From 03e8c65b8bd9f5d685486684291ed797c9c31dc6 Mon Sep 17 00:00:00 2001 From: Charles Kerr Date: Thu, 16 Aug 2018 13:56:03 -0700 Subject: [PATCH 4/4] chore: remove duplicate setting --- build/args/debug.gn | 1 - 1 file changed, 1 deletion(-) diff --git a/build/args/debug.gn b/build/args/debug.gn index 44ba86b3320..d6a28c48429 100644 --- a/build/args/debug.gn +++ b/build/args/debug.gn @@ -1,4 +1,3 @@ import("all.gn") is_debug = true is_component_build = true -use_jumbo_build = true