From 32e949efed094d8212d8aafd2e6d0e7f7ffb46c0 Mon Sep 17 00:00:00 2001 From: Jeff Wear Date: Wed, 2 Dec 2015 11:50:44 -0800 Subject: [PATCH] Read window size properly in `window.open` test `BrowserWindow#getSize` returns `[width, height]`, not `{width, height}`. --- spec/chromium-spec.coffee | 4 ++-- spec/fixtures/pages/window-open-size.html | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/spec/chromium-spec.coffee b/spec/chromium-spec.coffee index 435f7bbbe3e5..7aecde218dab 100644 --- a/spec/chromium-spec.coffee +++ b/spec/chromium-spec.coffee @@ -75,8 +75,8 @@ describe 'chromium feature', -> it 'inherit options of parent window', (done) -> listener = (event) -> - size = remote.getCurrentWindow().getSize() - assert.equal event.data, "size: #{size.width} #{size.height}" + [width, height] = remote.getCurrentWindow().getSize() + assert.equal event.data, "size: #{width} #{height}" b.close() done() window.addEventListener 'message', listener diff --git a/spec/fixtures/pages/window-open-size.html b/spec/fixtures/pages/window-open-size.html index b32e39889a4c..93b5039f7966 100644 --- a/spec/fixtures/pages/window-open-size.html +++ b/spec/fixtures/pages/window-open-size.html @@ -2,7 +2,7 @@