diff --git a/atom/browser/api/atom_api_app.cc b/atom/browser/api/atom_api_app.cc index 7331b66a8087..46cc4c26faf3 100644 --- a/atom/browser/api/atom_api_app.cc +++ b/atom/browser/api/atom_api_app.cc @@ -19,6 +19,7 @@ #include "native_mate/callback.h" #include "native_mate/dictionary.h" #include "native_mate/object_template_builder.h" +#include "net/base/load_flags.h" #include "net/proxy/proxy_service.h" #include "net/url_request/url_request_context.h" #include "net/url_request/url_request_context_getter.h" @@ -46,10 +47,10 @@ class ResolveProxyHelper { // Start the request. int result = proxy_service->ResolveProxy( - url, &proxy_info_, + url, net::LOAD_NORMAL, &proxy_info_, base::Bind(&ResolveProxyHelper::OnResolveProxyCompleted, base::Unretained(this)), - &pac_req_, net::BoundNetLog()); + &pac_req_, nullptr, net::BoundNetLog()); // Completed synchronously. if (result != net::ERR_IO_PENDING) diff --git a/atom/browser/api/atom_api_content_tracing.cc b/atom/browser/api/atom_api_content_tracing.cc index e5894a771ba2..81120461124f 100644 --- a/atom/browser/api/atom_api_content_tracing.cc +++ b/atom/browser/api/atom_api_content_tracing.cc @@ -3,6 +3,7 @@ // found in the LICENSE file. #include +#include #include "atom/common/native_mate_converters/file_path_converter.h" #include "base/bind.h" @@ -31,17 +32,30 @@ struct Converter > { }; template<> -struct Converter { +struct Converter { static bool FromV8(v8::Isolate* isolate, v8::Handle val, - TracingController::Options* out) { - if (!val->IsNumber()) + base::debug::CategoryFilter* out) { + std::string filter; + if (!ConvertFromV8(isolate, val, &filter)) return false; - *out = static_cast(val->IntegerValue()); + *out = base::debug::CategoryFilter(filter); return true; } }; +template<> +struct Converter { + static bool FromV8(v8::Isolate* isolate, + v8::Handle val, + base::debug::TraceOptions* out) { + std::string options; + if (!ConvertFromV8(isolate, val, &options)) + return false; + return out->SetFromString(options); + } +}; + } // namespace mate namespace { diff --git a/atom/browser/api/atom_api_web_contents.cc b/atom/browser/api/atom_api_web_contents.cc index 33abbcd75e93..a56688c616df 100644 --- a/atom/browser/api/atom_api_web_contents.cc +++ b/atom/browser/api/atom_api_web_contents.cc @@ -35,10 +35,10 @@ void WebContents::RenderProcessGone(base::TerminationStatus status) { Emit("crashed"); } -void WebContents::DidFinishLoad(int64 frame_id, - const GURL& validated_url, - bool is_main_frame, - content::RenderViewHost* render_view_host) { +void WebContents::DidFinishLoad(content::RenderFrameHost* render_frame_host, + const GURL& validated_url) { + bool is_main_frame = !render_frame_host->GetParent(); + base::ListValue args; args.AppendBoolean(is_main_frame); Emit("did-frame-finish-load", args); diff --git a/atom/browser/api/atom_api_web_contents.h b/atom/browser/api/atom_api_web_contents.h index 4a83153bca2b..145cd5aba9a8 100644 --- a/atom/browser/api/atom_api_web_contents.h +++ b/atom/browser/api/atom_api_web_contents.h @@ -52,11 +52,8 @@ class WebContents : public mate::EventEmitter, // content::WebContentsObserver implementations: virtual void RenderViewDeleted(content::RenderViewHost*) OVERRIDE; virtual void RenderProcessGone(base::TerminationStatus status) OVERRIDE; - virtual void DidFinishLoad( - int64 frame_id, - const GURL& validated_url, - bool is_main_frame, - content::RenderViewHost* render_view_host) OVERRIDE; + virtual void DidFinishLoad(content::RenderFrameHost* render_frame_host, + const GURL& validated_url) OVERRIDE; virtual void DidStartLoading( content::RenderViewHost* render_view_host) OVERRIDE; virtual void DidStopLoading( diff --git a/atom/browser/atom_browser_client.cc b/atom/browser/atom_browser_client.cc index ba3e8a69666c..22ff32ad219e 100644 --- a/atom/browser/atom_browser_client.cc +++ b/atom/browser/atom_browser_client.cc @@ -18,8 +18,8 @@ #include "content/public/browser/resource_dispatcher_host.h" #include "content/public/browser/site_instance.h" #include "content/public/browser/web_contents.h" +#include "content/public/common/web_preferences.h" #include "ui/base/l10n/l10n_util.h" -#include "webkit/common/webpreferences.h" namespace atom { @@ -76,7 +76,7 @@ content::AccessTokenStore* AtomBrowserClient::CreateAccessTokenStore() { void AtomBrowserClient::OverrideWebkitPrefs( content::RenderViewHost* render_view_host, const GURL& url, - WebPreferences* prefs) { + content::WebPreferences* prefs) { prefs->javascript_enabled = true; prefs->web_security_enabled = true; prefs->javascript_can_open_windows_automatically = true; diff --git a/atom/browser/atom_browser_client.h b/atom/browser/atom_browser_client.h index 344606c3ca2c..523b95143d0c 100644 --- a/atom/browser/atom_browser_client.h +++ b/atom/browser/atom_browser_client.h @@ -28,7 +28,7 @@ class AtomBrowserClient : public brightray::BrowserClient { virtual content::AccessTokenStore* CreateAccessTokenStore() OVERRIDE; virtual void OverrideWebkitPrefs(content::RenderViewHost* render_view_host, const GURL& url, - WebPreferences* prefs) OVERRIDE; + content::WebPreferences* prefs) OVERRIDE; virtual bool ShouldSwapBrowsingInstancesForNavigation( content::SiteInstance* site_instance, const GURL& current_url, diff --git a/atom/browser/native_window.cc b/atom/browser/native_window.cc index 583958cb24da..dfd589049638 100644 --- a/atom/browser/native_window.cc +++ b/atom/browser/native_window.cc @@ -44,13 +44,13 @@ #include "content/public/common/content_switches.h" #include "content/public/common/renderer_preferences.h" #include "content/public/common/user_agent.h" +#include "content/public/common/web_preferences.h" #include "ipc/ipc_message_macros.h" #include "native_mate/dictionary.h" #include "ui/gfx/codec/png_codec.h" #include "ui/gfx/point.h" #include "ui/gfx/rect.h" #include "ui/gfx/size.h" -#include "webkit/common/webpreferences.h" using content::NavigationEntry; @@ -248,9 +248,8 @@ bool NativeWindow::IsDevToolsOpened() { void NativeWindow::InspectElement(int x, int y) { OpenDevTools(); - content::RenderViewHost* rvh = GetWebContents()->GetRenderViewHost(); scoped_refptr agent( - content::DevToolsAgentHost::GetOrCreateFor(rvh)); + content::DevToolsAgentHost::GetOrCreateFor(GetWebContents())); agent->InspectElement(x, y); } @@ -287,7 +286,7 @@ void NativeWindow::CapturePage(const gfx::Rect& rect, base::Bind(&NativeWindow::OnCapturePageDone, weak_factory_.GetWeakPtr(), callback), - SkBitmap::kARGB_8888_Config); + kAlpha_8_SkColorType); } void NativeWindow::DestroyWebContents() { @@ -368,7 +367,8 @@ void NativeWindow::AppendExtraCommandLineSwitches( } } -void NativeWindow::OverrideWebkitPrefs(const GURL& url, WebPreferences* prefs) { +void NativeWindow::OverrideWebkitPrefs(const GURL& url, + content::WebPreferences* prefs) { if (web_preferences_.IsEmpty()) return; diff --git a/atom/browser/native_window.h b/atom/browser/native_window.h index 929c1aabc5bb..0a2abb7059c8 100644 --- a/atom/browser/native_window.h +++ b/atom/browser/native_window.h @@ -23,8 +23,6 @@ #include "native_mate/persistent_dictionary.h" #include "ui/gfx/image/image_skia.h" -struct WebPreferences; - namespace base { class CommandLine; } @@ -32,6 +30,7 @@ class CommandLine; namespace content { class BrowserContext; class WebContents; +struct WebPreferences; } namespace gfx { @@ -178,7 +177,7 @@ class NativeWindow : public brightray::DefaultWebContentsDelegate, // Called when renderer process is going to be started. void AppendExtraCommandLineSwitches(base::CommandLine* command_line, int child_process_id); - void OverrideWebkitPrefs(const GURL& url, WebPreferences* prefs); + void OverrideWebkitPrefs(const GURL& url, content::WebPreferences* prefs); // Public API used by platform-dependent delegates and observers to send UI // related notifications. diff --git a/atom/browser/net/asar/url_request_asar_job.cc b/atom/browser/net/asar/url_request_asar_job.cc index a66eaf57d717..9c0bab951b94 100644 --- a/atom/browser/net/asar/url_request_asar_job.cc +++ b/atom/browser/net/asar/url_request_asar_job.cc @@ -99,7 +99,7 @@ void URLRequestAsarJob::DidOpen(int result) { return; } - int rv = stream_->Seek(net::FROM_BEGIN, + int rv = stream_->Seek(base::File::FROM_BEGIN, file_info_.offset, base::Bind(&URLRequestAsarJob::DidSeek, weak_ptr_factory_.GetWeakPtr())); diff --git a/atom/browser/ui/accelerator_util.cc b/atom/browser/ui/accelerator_util.cc index 16251e822c6f..7d075ce0bde8 100644 --- a/atom/browser/ui/accelerator_util.cc +++ b/atom/browser/ui/accelerator_util.cc @@ -91,7 +91,7 @@ bool StringToAccelerator(const std::string& description, LOG(ERROR) << "The accelerator string can only contain ASCII characters"; return false; } - std::string shortcut(StringToLowerASCII(description)); + std::string shortcut(base::StringToLowerASCII(description)); std::vector tokens; base::SplitString(shortcut, '+', &tokens); diff --git a/atom/common/api/api_messages.h b/atom/common/api/api_messages.h index 045bceb719af..bd8bfd5a06eb 100644 --- a/atom/common/api/api_messages.h +++ b/atom/common/api/api_messages.h @@ -9,6 +9,7 @@ #include "base/values.h" #include "content/public/common/common_param_traits.h" #include "ipc/ipc_message_macros.h" +#include "ui/gfx/ipc/gfx_param_traits.h" // The message starter should be declared in ipc/ipc_message_start.h. Since // we don't want to patch Chromium, we just pretend to be Content Shell. diff --git a/chromium_src/chrome/renderer/printing/print_web_view_helper.cc b/chromium_src/chrome/renderer/printing/print_web_view_helper.cc index b962f45112fb..df9e287cdcbb 100644 --- a/chromium_src/chrome/renderer/printing/print_web_view_helper.cc +++ b/chromium_src/chrome/renderer/printing/print_web_view_helper.cc @@ -17,10 +17,10 @@ #include "base/strings/stringprintf.h" #include "base/strings/utf_string_conversions.h" #include "chrome/common/print_messages.h" +#include "content/public/common/web_preferences.h" #include "content/public/renderer/render_frame.h" #include "content/public/renderer/render_thread.h" #include "content/public/renderer/render_view.h" -#include "content/public/renderer/web_preferences.h" #include "net/base/escape.h" #include "printing/metafile.h" #include "printing/metafile_impl.h" @@ -42,7 +42,8 @@ #include "third_party/WebKit/public/web/WebView.h" #include "third_party/WebKit/public/web/WebViewClient.h" #include "ui/base/resource/resource_bundle.h" -#include "webkit/common/webpreferences.h" + +using content::WebPreferences; namespace printing { @@ -547,7 +548,7 @@ void PrepareFrameAndViewForPrint::CopySelection( blink::WebView* web_view = blink::WebView::create(this); owns_web_view_ = true; - content::ApplyWebPreferences(prefs, web_view); + content::RenderView::ApplyWebPreferences(prefs, web_view); web_view->setMainFrame(blink::WebLocalFrame::create(this)); frame_.Reset(web_view->mainFrame()->toWebLocalFrame()); node_to_print_.reset();