mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

Merge pull request #6713 from MaxWhere/offscreen-rendering-fixes

Browse source 
Fixes buffer size in offscreen mode
This commit is contained in:
Cheng Zhao 2016-08-04 13:00:54 +09:00 • committed by GitHub
commit 32d9382417
7 changed files with 20 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

15
atom/browser/api/atom_api_web_contents.cc
View file

@ -1345,11 +1345,18 @@ bool WebContents::IsOffScreen() const {
void WebContents::OnPaint(const gfx::Rect& dirty_rect,
const gfx::Size& bitmap_size,
int pixel_size,
void* bitmap_pixels) {
v8::MaybeLocal<v8::Object> buffer = node::Buffer::New(
isolate(), reinterpret_cast<char*>(bitmap_pixels), sizeof(bitmap_pixels));
v8::MaybeLocal<v8::Object> buffer = node::Buffer::Copy(
isolate(), reinterpret_cast<char*>(bitmap_pixels),
pixel_size * bitmap_size.width() * bitmap_size.height());
mate::Dictionary dict = mate::Dictionary::CreateEmpty(isolate());
dict.Set("width", bitmap_size.width());
dict.Set("height", bitmap_size.height());
if (!buffer.IsEmpty())
Emit("paint", dirty_rect, buffer.ToLocalChecked(), bitmap_size);
Emit("paint", dirty_rect, buffer.ToLocalChecked(), dict);
}
void WebContents::StartPainting() {
@ -1359,8 +1366,8 @@ void WebContents::StartPainting() {
auto* osr_rwhv = static_cast<OffScreenRenderWidgetHostView*>(
web_contents()->GetRenderWidgetHostView());
if (osr_rwhv) {
osr_rwhv->SetPainting(true);
osr_rwhv->Show();
osr_rwhv->SetPainting(true);
}
}

1
atom/browser/api/atom_api_web_contents.h
View file

@ -160,6 +160,7 @@ class WebContents : public mate::TrackableObject<WebContents>,
bool IsOffScreen() const;
void OnPaint(const gfx::Rect& dirty_rect,
const gfx::Size& bitmap_size,
const int pixel_size,
void* bitmap_pixels);
void StartPainting();
void StopPainting();