mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

fix: getNormalBounds() for transparent windows on Windows (#38218)

Browse source
This commit is contained in:
Shelley Vohr 2023-05-17 13:11:43 +02:00 committed by GitHub
parent ad07712561
commit 32d8f84cad
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 21 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
shell/browser/native_window_views.cc
View file

@ -787,6 +787,10 @@ gfx::Size NativeWindowViews::GetContentSize() {
}
gfx::Rect NativeWindowViews::GetNormalBounds() {
#if BUILDFLAG(IS_WIN)
if (IsMaximized() && transparent())
return restore_bounds_;
#endif
return widget()->GetRestoredBounds();
}

17
spec/api-browser-window-spec.ts
View file

@ -1720,6 +1720,23 @@ describe('BrowserWindow module', () => {
expect(w.isFullScreen()).to.equal(true);
});
it('checks normal bounds for maximized transparent window', async () => {
w.destroy();
w = new BrowserWindow({
transparent: true,
show: false
});
w.show();
const bounds = w.getNormalBounds();
const maximize = once(w, 'maximize');
w.maximize();
await maximize;
expectBoundsEqual(w.getNormalBounds(), bounds);
});
it('does not change size for a frameless window with min size', async () => {
w.destroy();
w = new BrowserWindow({