From 32af863e3478fed9434a8953b72033ed3359c14a Mon Sep 17 00:00:00 2001 From: Cheng Zhao Date: Tue, 14 Jan 2020 04:37:11 +0900 Subject: [PATCH] fix: double-autorelease of NSImage (#21757) --- shell/browser/native_window_mac.mm | 26 +++++++++++++------------- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/shell/browser/native_window_mac.mm b/shell/browser/native_window_mac.mm index a13dd350cb1a..3ba2ea8abfd9 100644 --- a/shell/browser/native_window_mac.mm +++ b/shell/browser/native_window_mac.mm @@ -1373,21 +1373,21 @@ void NativeWindowMac::SetVibrancy(const std::string& type) { [effect_view setBlendingMode:NSVisualEffectBlendingModeBehindWindow]; [effect_view setState:NSVisualEffectStateActive]; - // The default corner radius of a macOS window. - CGFloat radius = 5.0f; + // Make frameless Vibrant windows have rounded corners. + CGFloat radius = 5.0f; // default corner radius CGFloat dimension = 2 * radius + 1; NSSize size = NSMakeSize(dimension, dimension); - NSImage* maskImage = [[NSImage imageWithSize:size - flipped:NO - drawingHandler:^BOOL(NSRect rect) { - NSBezierPath* bezierPath = [NSBezierPath - bezierPathWithRoundedRect:rect - xRadius:radius - yRadius:radius]; - [[NSColor blackColor] set]; - [bezierPath fill]; - return YES; - }] autorelease]; + NSImage* maskImage = [NSImage imageWithSize:size + flipped:NO + drawingHandler:^BOOL(NSRect rect) { + NSBezierPath* bezierPath = [NSBezierPath + bezierPathWithRoundedRect:rect + xRadius:radius + yRadius:radius]; + [[NSColor blackColor] set]; + [bezierPath fill]; + return YES; + }]; [maskImage setCapInsets:NSEdgeInsetsMake(radius, radius, radius, radius)]; [maskImage setResizingMode:NSImageResizingModeStretch];