mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

Should override the virtual destructor.

Browse source
This commit is contained in:
Haojian Wu 2017-03-30 23:13:23 +02:00
parent e8abee9ca9
commit 328cf4789b
2 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
atom/browser/net/atom_cert_verifier.cc
View file

@ -50,7 +50,7 @@ class CertVerifierRequest : public AtomCertVerifier::Request {
first_response_(true), first_response_(true),
weak_ptr_factory_(this) {} weak_ptr_factory_(this) {}
~CertVerifierRequest() { ~CertVerifierRequest() override {
cert_verifier_->RemoveRequest(params_); cert_verifier_->RemoveRequest(params_);
default_verifier_request_.reset(); default_verifier_request_.reset();
while (!response_list_.empty() && !first_response_) { while (!response_list_.empty() && !first_response_) {

2
atom/browser/web_dialog_helper.cc
View file

@ -51,7 +51,7 @@ class FileSelectHelper : public base::RefCounted<FileSelectHelper>,
private: private:
friend class base::RefCounted<FileSelectHelper>; friend class base::RefCounted<FileSelectHelper>;
~FileSelectHelper() {} ~FileSelectHelper() override {}
void OnOpenDialogDone(bool result, const std::vector<base::FilePath>& paths) { void OnOpenDialogDone(bool result, const std::vector<base::FilePath>& paths) {
std::vector<content::FileChooserFileInfo> file_info; std::vector<content::FileChooserFileInfo> file_info;