mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

fix: flaky utility and BrowserView tests (#44451)

Browse source 
* fix: flake wait for crash with specific serviceName

* fix: flake when unrelated WebContents exists during BrowserView tests

* fix: wait for crash before forking

* use name
This commit is contained in:
Sam Maddock 2024-10-30 21:29:01 -04:00 • committed by GitHub
parent 7cdf1a01b8
commit 31f8e7553b
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 31 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

25
spec/api-utility-process-spec.ts
View file

@ -144,21 +144,36 @@ describe('utilityProcess module', () => {
});
describe('app \'child-process-gone\' event', () => {
const waitForCrash = (name: string) => {
return new Promise<Electron.Details>((resolve) => {
app.on('child-process-gone', function onCrash (_event, details) {
if (details.name === name) {
app.off('child-process-gone', onCrash);
resolve(details);
}
});
});
};
ifit(!isWindows32Bit)('with default serviceName', async () => {
const name = 'Node Utility Process';
const crashPromise = waitForCrash(name);
utilityProcess.fork(path.join(fixturesPath, 'crash.js'));
const [, details] = await once(app, 'child-process-gone') as [any, Electron.Details];
const details = await crashPromise;
expect(details.type).to.equal('Utility');
expect(details.serviceName).to.equal('node.mojom.NodeService');
expect(details.name).to.equal('Node Utility Process');
expect(details.name).to.equal(name);
expect(details.reason).to.be.oneOf(['crashed', 'abnormal-exit']);
});
ifit(!isWindows32Bit)('with custom serviceName', async () => {
utilityProcess.fork(path.join(fixturesPath, 'crash.js'), [], { serviceName: 'Hello World!' });
const [, details] = await once(app, 'child-process-gone') as [any, Electron.Details];
const name = crypto.randomUUID();
const crashPromise = waitForCrash(name);
utilityProcess.fork(path.join(fixturesPath, 'crash.js'), [], { serviceName: name });
const details = await crashPromise;
expect(details.type).to.equal('Utility');
expect(details.serviceName).to.equal('node.mojom.NodeService');
expect(details.name).to.equal('Hello World!');
expect(details.name).to.equal(name);
expect(details.reason).to.be.oneOf(['crashed', 'abnormal-exit']);
});
});