perf: avoid redundant calls to GetView() (#43231)
* perf: avoid double-calls to GetView() There are a lot of places where we call the virtual method GetView() twice in succession: the first to check if the view exists, and the second to use. This PR holds the view in a temp variable instead, e.g.: if (auto* view = foo->GetView()) view->DoSomething(); Co-authored-by: Charles Kerr <charles@charleskerr.com> * perf: avoid discarded GetView() call Co-authored-by: Charles Kerr <charles@charleskerr.com> --------- Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com> Co-authored-by: Charles Kerr <charles@charleskerr.com>
This commit is contained in:
parent
22b66ee6de
commit
31e6d66c74
4 changed files with 20 additions and 28 deletions
|
@ -565,10 +565,8 @@ OffScreenRenderWidgetHostView::CreateViewForWidget(
|
|||
content::RenderWidgetHost* render_widget_host,
|
||||
content::RenderWidgetHost* embedder_render_widget_host,
|
||||
content::WebContentsView* web_contents_view) {
|
||||
if (render_widget_host->GetView()) {
|
||||
return static_cast<content::RenderWidgetHostViewBase*>(
|
||||
render_widget_host->GetView());
|
||||
}
|
||||
if (auto* rwhv = render_widget_host->GetView())
|
||||
return static_cast<content::RenderWidgetHostViewBase*>(rwhv);
|
||||
|
||||
OffScreenRenderWidgetHostView* embedder_host_view = nullptr;
|
||||
if (embedder_render_widget_host) {
|
||||
|
|
|
@ -33,8 +33,8 @@ void OffScreenWebContentsView::SetWebContents(
|
|||
content::WebContents* web_contents) {
|
||||
web_contents_ = web_contents;
|
||||
|
||||
if (GetView())
|
||||
GetView()->InstallTransparency();
|
||||
if (auto* view = GetView())
|
||||
view->InstallTransparency();
|
||||
}
|
||||
|
||||
void OffScreenWebContentsView::SetNativeWindow(NativeWindow* window) {
|
||||
|
@ -51,8 +51,8 @@ void OffScreenWebContentsView::SetNativeWindow(NativeWindow* window) {
|
|||
|
||||
void OffScreenWebContentsView::OnWindowResize() {
|
||||
// In offscreen mode call RenderWidgetHostView's SetSize explicitly
|
||||
if (GetView())
|
||||
GetView()->SetSize(GetSize());
|
||||
if (auto* view = GetView())
|
||||
view->SetSize(GetSize());
|
||||
}
|
||||
|
||||
void OffScreenWebContentsView::OnWindowClosed() {
|
||||
|
@ -105,7 +105,9 @@ content::DropData* OffScreenWebContentsView::GetDropData() const {
|
|||
}
|
||||
|
||||
gfx::Rect OffScreenWebContentsView::GetViewBounds() const {
|
||||
return GetView() ? GetView()->GetViewBounds() : gfx::Rect();
|
||||
if (auto* view = GetView())
|
||||
return view->GetViewBounds();
|
||||
return {};
|
||||
}
|
||||
|
||||
void OffScreenWebContentsView::CreateView(gfx::NativeView context) {}
|
||||
|
@ -113,10 +115,8 @@ void OffScreenWebContentsView::CreateView(gfx::NativeView context) {}
|
|||
content::RenderWidgetHostViewBase*
|
||||
OffScreenWebContentsView::CreateViewForWidget(
|
||||
content::RenderWidgetHost* render_widget_host) {
|
||||
if (render_widget_host->GetView()) {
|
||||
return static_cast<content::RenderWidgetHostViewBase*>(
|
||||
render_widget_host->GetView());
|
||||
}
|
||||
if (auto* rwhv = render_widget_host->GetView())
|
||||
return static_cast<content::RenderWidgetHostViewBase*>(rwhv);
|
||||
|
||||
return new OffScreenRenderWidgetHostView(
|
||||
transparent_, painting_, GetFrameRate(), callback_, render_widget_host,
|
||||
|
@ -142,8 +142,8 @@ OffScreenWebContentsView::CreateViewForChildWidget(
|
|||
void OffScreenWebContentsView::SetPageTitle(const std::u16string& title) {}
|
||||
|
||||
void OffScreenWebContentsView::RenderViewReady() {
|
||||
if (GetView())
|
||||
GetView()->InstallTransparency();
|
||||
if (auto* view = GetView())
|
||||
view->InstallTransparency();
|
||||
}
|
||||
|
||||
void OffScreenWebContentsView::RenderViewHostChanged(
|
||||
|
@ -179,11 +179,9 @@ void OffScreenWebContentsView::UpdateDragOperation(
|
|||
bool document_is_handling_drag) {}
|
||||
|
||||
void OffScreenWebContentsView::SetPainting(bool painting) {
|
||||
auto* view = GetView();
|
||||
painting_ = painting;
|
||||
if (view != nullptr) {
|
||||
if (auto* view = GetView())
|
||||
view->SetPainting(painting);
|
||||
}
|
||||
}
|
||||
|
||||
bool OffScreenWebContentsView::IsPainting() const {
|
||||
|
@ -193,11 +191,9 @@ bool OffScreenWebContentsView::IsPainting() const {
|
|||
}
|
||||
|
||||
void OffScreenWebContentsView::SetFrameRate(int frame_rate) {
|
||||
auto* view = GetView();
|
||||
frame_rate_ = frame_rate;
|
||||
if (view != nullptr) {
|
||||
if (auto* view = GetView())
|
||||
view->SetFrameRate(frame_rate);
|
||||
}
|
||||
}
|
||||
|
||||
int OffScreenWebContentsView::GetFrameRate() const {
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue