fix: shutdown after message loop is ready (#16671)

This commit is contained in:
Cheng Zhao 2019-02-02 00:21:49 +09:00 committed by John Kleinschmidt
parent ab503c7e43
commit 31c7ed9b8c
7 changed files with 14 additions and 38 deletions

View file

@ -1211,13 +1211,6 @@ describe('default behavior', () => {
})
describe('window-all-closed', () => {
before(function () {
// FIXME(jkleinsc): Test is consistently failing on Windows 32 bit.
if (process.arch === 'ia32') {
this.skip()
}
})
it('quits when the app does not handle the event', async () => {
const result = await runTestApp('window-all-closed')
expect(result).to.equal(false)

View file

@ -228,13 +228,6 @@ describe('BrowserView module', () => {
})
describe('new BrowserView()', () => {
before(function () {
// FIXME(jkleinsc): Test is consistently failing on Windows 32 bit.
if (process.arch === 'ia32') {
this.skip()
}
})
it('does not crash on exit', async () => {
const appPath = path.join(fixtures, 'api', 'leak-exit-browserview.js')
const electronPath = remote.getGlobal('process').execPath

View file

@ -916,13 +916,6 @@ describe('webContents module', () => {
})
describe('create()', () => {
before(function () {
// FIXME(jkleinsc): Test is consistently failing on Windows 32 bit.
if (process.arch === 'ia32') {
this.skip()
}
})
it('does not crash on exit', async () => {
const appPath = path.join(__dirname, 'fixtures', 'api', 'leak-exit-webcontents.js')
const electronPath = remote.getGlobal('process').execPath

View file

@ -34,13 +34,6 @@ describe('WebContentsView', () => {
})
describe('new WebContentsView()', () => {
before(function () {
// FIXME(jkleinsc): Test is consistently failing on Windows 32 bit.
if (process.arch === 'ia32') {
this.skip()
}
})
it('does not crash on exit', async () => {
const appPath = path.join(__dirname, 'fixtures', 'api', 'leak-exit-webcontentsview.js')
const electronPath = remote.getGlobal('process').execPath