mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

feedback from review

Browse source
This commit is contained in:
Shelley Vohr 2018-06-18 08:12:54 -07:00
parent 2c2e8317de
commit 314071d79f
No known key found for this signature in database
GPG key ID: F13993A75599653C
1 changed files with 7 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

15
spec/api-desktop-capturer-spec.js
View file

@ -26,7 +26,7 @@ describe('desktopCapturer', () => {
types: ['window', 'screen'] types: ['window', 'screen']
}, (error, sources) => { }, (error, sources) => {
expect(error).to.be.null() expect(error).to.be.null()
expect(sources.length).to.not.equal(0) expect(sources).to.be.an('array').that.is.not.empty()
done() done()
}) })
}) })
@ -43,7 +43,7 @@ describe('desktopCapturer', () => {
const callback = (error, sources) => { const callback = (error, sources) => {
callCount++ callCount++
expect(error).to.be.null() expect(error).to.be.null()
expect(sources.length).to.not.equal(0) expect(sources).to.be.an('array').that.is.not.empty()
if (callCount === 2) done() if (callCount === 2) done()
} }
@ -71,10 +71,10 @@ describe('desktopCapturer', () => {
desktopCapturer.getSources({types: ['window']}, (error, sources) => { desktopCapturer.getSources({types: ['window']}, (error, sources) => {
expect(error).to.be.null() expect(error).to.be.null()
expect(sources.length).to.not.equal(0) expect(sources).to.be.an('array').that.is.not.empty()
sources.forEach((source) => { for (const {display_id: displayId} of sources) {
expect(source.display_id.length).to.equal(0) expect(displayId).to.be.a('string').and.be.empty()
}) }
done() done()
}) })
}) })
@ -87,8 +87,7 @@ describe('desktopCapturer', () => {
const displays = screen.getAllDisplays() const displays = screen.getAllDisplays()
desktopCapturer.getSources({types: ['screen']}, (error, sources) => { desktopCapturer.getSources({types: ['screen']}, (error, sources) => {
expect(error).to.be.null() expect(error).to.be.null()
expect(sources.length).to.not.equal(0) expect(sources).to.be.an('array').of.length(displays.length)
expect(sources.length).to.equal(displays.length)
for (let i = 0; i < sources.length; i++) { for (let i = 0; i < sources.length; i++) {
expect(sources[i].display_id).to.equal(displays[i].id.toString()) expect(sources[i].display_id).to.equal(displays[i].id.toString())