mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

fix: performance-no-automatic-move clang-tidy warnings (#44772)

Browse source 
* fix: performance-no-automatic-move in GetLogFileName()

remove `const` from log_filename.

Warning fixed by this commit:

../../electron/shell/common/logging.cc:40:12: warning: constness of 'log_filename' prevents automatic move [performance-no-automatic-move]

Co-authored-by: Charles Kerr <charles@charleskerr.com>

* fix: performance-no-automatic-move in GetBundleResourcePath()

remove `const` from request_relative_path.

Warning fixed by this commit:

electron/shell/browser/extensions/electron_extensions_browser_client.cc:187:10: warning: constness of 'request_relative_path' prevents automatic move [performance-no-automatic-move]

Co-authored-by: Charles Kerr <charles@charleskerr.com>

---------

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
This commit is contained in:
trop[bot] 2024-11-22 10:23:05 +01:00 committed by GitHub
parent 0e001fc45a
commit 3137994b4a
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 7 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
shell/browser/extensions/electron_extensions_browser_client.cc
View file

@ -178,7 +178,7 @@ base::FilePath ElectronExtensionsBrowserClient::GetBundleResourcePath(
if (!chrome_resources_path.IsParent(extension_resources_path)) if (!chrome_resources_path.IsParent(extension_resources_path))
return base::FilePath(); return base::FilePath();
const base::FilePath request_relative_path = base::FilePath request_relative_path =
extensions::file_util::ExtensionURLToRelativeFilePath(request.url); extensions::file_util::ExtensionURLToRelativeFilePath(request.url);
if (!ExtensionsBrowserClient::Get() if (!ExtensionsBrowserClient::Get()
->GetComponentExtensionResourceManager() ->GetComponentExtensionResourceManager()

15
shell/common/logging.cc
View file

@ -30,16 +30,13 @@ base::FilePath GetLogFileName(const base::CommandLine& command_line) {
if (!filename.empty()) if (!filename.empty())
return base::FilePath::FromUTF8Unsafe(filename); return base::FilePath::FromUTF8Unsafe(filename);
const base::FilePath log_filename(FILE_PATH_LITERAL("electron_debug.log")); auto log_filename = base::FilePath{FILE_PATH_LITERAL("electron_debug.log")};
base::FilePath log_path;
if (base::PathService::Get(chrome::DIR_LOGS, &log_path)) { if (base::FilePath path; base::PathService::Get(chrome::DIR_LOGS, &path))
log_path = log_path.Append(log_filename); return path.Append(log_filename);
return log_path;
} else { // error with path service, just use some default file somewhere
// error with path service, just use some default file somewhere return log_filename;
return log_filename;
}
} }
namespace { namespace {