mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

refactor: remove private webContents.getId() API (#13674)

Browse source
This commit is contained in:
Cheng Zhao 2018-07-23 18:08:36 +09:00 • committed by GitHub
parent a88cdf2d1f
commit 305e3aad40
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
12 changed files with 14 additions and 45 deletions
Download patch file Download diff file Expand all files Collapse all files

4
spec/webview-spec.js
View file

@ -1035,7 +1035,7 @@ describe('<webview> tag', function () {
assert.ok(webview.partition)
const listener = function (webContents, permission, callback) {
if (webContents.getId() === webview.getId()) {
if (webContents.id === webview.getWebContents().id) {
// requestMIDIAccess with sysex requests both midi and midiSysex so
// grant the first midi one and then reject the midiSysex one
if (requestedPermission === 'midiSysex' && permission === 'midi') {
@ -1121,7 +1121,7 @@ describe('<webview> tag', function () {
webview.partition = 'permissionTest'
webview.setAttribute('nodeintegration', 'on')
session.fromPartition(webview.partition).setPermissionRequestHandler((webContents, permission, callback) => {
if (webContents.getId() === webview.getId()) {
if (webContents.id === webview.getWebContents().id) {
assert.equal(permission, 'notifications')
setTimeout(() => { callback(true) }, 10)
}