mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

refactor: remove private webContents.getId() API (#13674)

Browse source
This commit is contained in:
Cheng Zhao 2018-07-23 18:08:36 +09:00 • committed by GitHub
parent a88cdf2d1f
commit 305e3aad40
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
12 changed files with 14 additions and 45 deletions
Download patch file Download diff file Expand all files Collapse all files

8
spec/api-web-contents-spec.js
View file

@ -40,7 +40,7 @@ describe('webContents module', () => {
it('returns an array of web contents', (done) => {
w.webContents.on('devtools-opened', () => {
const all = webContents.getAllWebContents().sort((a, b) => {
return a.getId() - b.getId()
return a.id - b.id
})
assert.ok(all.length >= 4)
@ -61,15 +61,15 @@ describe('webContents module', () => {
if (isCi) return done()
const specWebContents = remote.getCurrentWebContents()
assert.equal(specWebContents.getId(), webContents.getFocusedWebContents().getId())
assert.equal(specWebContents.id, webContents.getFocusedWebContents().id)
specWebContents.once('devtools-opened', () => {
assert.equal(specWebContents.devToolsWebContents.getId(), webContents.getFocusedWebContents().getId())
assert.equal(specWebContents.devToolsWebContents.id, webContents.getFocusedWebContents().id)
specWebContents.closeDevTools()
})
specWebContents.once('devtools-closed', () => {
assert.equal(specWebContents.getId(), webContents.getFocusedWebContents().getId())
assert.equal(specWebContents.id, webContents.getFocusedWebContents().id)
done()
})