mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

test: fix a bunch of flaky tests related to emittedOnce (#15871)

Browse source
This commit is contained in:
Jeremy Apthorp 2018-11-28 17:52:19 -08:00 • committed by GitHub
parent ae266e2e03
commit 30109d64f2
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 57 additions and 33 deletions
Download patch file Download diff file Expand all files Collapse all files

24
spec/api-web-contents-spec.js
View file

@ -137,12 +137,14 @@ describe('webContents module', () => {
const oscillator = context.createOscillator()
oscillator.connect(context.destination)
oscillator.start()
let p = emittedOnce(webContents, '-audio-state-changed')
await context.resume()
const [, audible] = await emittedOnce(webContents, '-audio-state-changed')
const [, audible] = await p
assert(webContents.isCurrentlyAudible() === audible)
expect(webContents.isCurrentlyAudible()).to.be.true()
p = emittedOnce(webContents, '-audio-state-changed')
oscillator.stop()
await emittedOnce(webContents, '-audio-state-changed')
await p
expect(webContents.isCurrentlyAudible()).to.be.false()
oscillator.disconnect()
context.close()
@ -163,14 +165,16 @@ describe('webContents module', () => {
it('can show window with activation', async () => {
w.show()
assert.strictEqual(w.isFocused(), true)
const devtoolsOpened = emittedOnce(w.webContents, 'devtools-opened')
w.webContents.openDevTools({ mode: 'detach', activate: true })
await emittedOnce(w.webContents, 'devtools-opened')
await devtoolsOpened
assert.strictEqual(w.isFocused(), false)
})
it('can show window without activation', async () => {
const devtoolsOpened = emittedOnce(w.webContents, 'devtools-opened')
w.webContents.openDevTools({ mode: 'detach', activate: false })
await emittedOnce(w.webContents, 'devtools-opened')
await devtoolsOpened
assert.strictEqual(w.isDevToolsOpened(), true)
})
})
@ -496,7 +500,6 @@ describe('webContents module', () => {
})
it('can set the correct zoom level', (done) => {
w.loadURL('about:blank')
w.webContents.on('did-finish-load', () => {
w.webContents.getZoomLevel((zoomLevel) => {
assert.strictEqual(zoomLevel, 0.0)
@ -508,6 +511,7 @@ describe('webContents module', () => {
})
})
})
w.loadURL('about:blank')
})
it('can persist zoom level across navigation', (done) => {
@ -895,8 +899,9 @@ describe('webContents module', () => {
}
})
const p = emittedOnce(w.webContents, 'did-finish-load')
w.loadURL('about:blank')
await emittedOnce(w.webContents, 'did-finish-load')
await p
const filePath = path.join(remote.app.getPath('temp'), 'test.heapsnapshot')
@ -926,8 +931,9 @@ describe('webContents module', () => {
}
})
const p = emittedOnce(w.webContents, 'did-finish-load')
w.loadURL('about:blank')
await emittedOnce(w.webContents, 'did-finish-load')
await p
const promise = w.webContents.takeHeapSnapshot('')
return expect(promise).to.be.eventually.rejectedWith(Error, 'takeHeapSnapshot failed')
@ -979,12 +985,12 @@ describe('webContents module', () => {
sandbox: true
}
})
w.loadURL('data:text/html,%3Ch1%3EHello%2C%20World!%3C%2Fh1%3E')
w.webContents.once('did-finish-load', () => {
const printers = w.webContents.getPrinters()
assert.strictEqual(Array.isArray(printers), true)
done()
})
w.loadURL('data:text/html,%3Ch1%3EHello%2C%20World!%3C%2Fh1%3E')
})
})
@ -1006,7 +1012,6 @@ describe('webContents module', () => {
sandbox: true
}
})
w.loadURL('data:text/html,%3Ch1%3EHello%2C%20World!%3C%2Fh1%3E')
w.webContents.once('did-finish-load', () => {
w.webContents.printToPDF({}, function (error, data) {
assert.strictEqual(error, null)
@ -1015,6 +1020,7 @@ describe('webContents module', () => {
done()
})
})
w.loadURL('data:text/html,%3Ch1%3EHello%2C%20World!%3C%2Fh1%3E')
})
})
})