fix: CHECK when adding view as its own child (#42108)

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
This commit is contained in:
trop[bot] 2024-05-10 10:30:58 +02:00 committed by GitHub
parent 12bc4dc6c0
commit 2fc89a6b2c
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 19 additions and 1 deletions

View file

@ -1,3 +1,4 @@
import { expect } from 'chai';
import { closeWindow } from './lib/window-helpers';
import { BaseWindow, View } from 'electron/main';
@ -10,6 +11,15 @@ describe('View', () => {
it('can be used as content view', () => {
w = new BaseWindow({ show: false });
w.setContentView(new View());
const v = new View();
w.setContentView(v);
expect(w.contentView).to.equal(v);
});
it('will throw when added as a child to itself', () => {
w = new BaseWindow({ show: false });
expect(() => {
w.contentView.addChildView(w.contentView);
}).to.throw('A view cannot be added as its own child');
});
});