mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge pull request #228 from tensor5/no-whole-archive

Browse source 
Replace --whole-archive with --start-group
This commit is contained in:
Cheng Zhao 2016-06-21 03:23:51 +00:00 committed by GitHub
commit 2fb73a266a
1 changed files with 5 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
brightray/brightray.gyp
View file

@ -36,14 +36,13 @@
'conditions': [ 'conditions': [
# Link with libraries of libchromiumcontent. # Link with libraries of libchromiumcontent.
['OS=="linux" and libchromiumcontent_component==0', { ['OS=="linux" and libchromiumcontent_component==0', {
# On Linux we have to use "--whole-archive" to force executable # On Linux we have to use "--start-group" or we will have plenty of
# to include all symbols, otherwise we will have plenty of
# unresolved symbols errors. # unresolved symbols errors.
'direct_dependent_settings': { 'link_settings': {
'ldflags': [ 'libraries': [
'-Wl,--whole-archive', '-Wl,--start-group',
'<@(libchromiumcontent_libraries)', '<@(libchromiumcontent_libraries)',
'-Wl,--no-whole-archive', '-Wl,--end-group'
], ],
} }
}, { # (Release build on Linux) }, { # (Release build on Linux)