refactor: use v8 serialization for ipc (#20214)
* refactor: use v8 serialization for ipc * cloning process.env doesn't work * serialize host objects by enumerating key/values * new serialization can handle NaN, Infinity, and undefined correctly * can't allocate v8 objects during GC * backport microtasks fix * fix compile * fix node_stream_loader reentrancy * update subframe spec to expect undefined instead of null * write undefined instead of crashing when serializing host objects * fix webview spec * fix download spec * buffers are transformed into uint8arrays * can't serialize promises * fix chrome.i18n.getMessage * fix devtools tests * fix zoom test * fix debug build * fix lint * update ipcRenderer tests * fix printToPDF test * update patch * remove accidentally re-added remote-side spec * wip * don't attempt to serialize host objects * jump through different hoops to set options.webContents sometimes * whoops * fix lint * clean up error-handling logic * fix memory leak * fix lint * convert host objects using old base::Value serialization * fix lint more * fall back to base::Value-based serialization * remove commented-out code * add docs to breaking-changes.md * Update breaking-changes.md * update ipcRenderer and WebContents docs * lint * use named values for format tag * save a memcpy for ~30% speedup * get rid of calls to ShallowClone * extra debugging for paranoia * d'oh, use the correct named tags * apparently msstl doesn't like this DCHECK * funny story about that DCHECK * disable remote-related functions when enable_remote_module = false * nits * use EnableIf to disable remote methods in mojom * fix include * review comments
This commit is contained in:
parent
c250cd6e7c
commit
2fad53e66b
38 changed files with 623 additions and 169 deletions
|
@ -241,14 +241,14 @@ ifdescribe(features.isRemoteModuleEnabled())('remote module', () => {
|
|||
const print = path.join(fixtures, 'module', 'print_name.js')
|
||||
const printName = remote.require(print)
|
||||
|
||||
it('converts NaN to undefined', () => {
|
||||
expect(printName.getNaN()).to.be.undefined()
|
||||
expect(printName.echo(NaN)).to.be.undefined()
|
||||
it('preserves NaN', () => {
|
||||
expect(printName.getNaN()).to.be.NaN()
|
||||
expect(printName.echo(NaN)).to.be.NaN()
|
||||
})
|
||||
|
||||
it('converts Infinity to undefined', () => {
|
||||
expect(printName.getInfinity()).to.be.undefined()
|
||||
expect(printName.echo(Infinity)).to.be.undefined()
|
||||
it('preserves Infinity', () => {
|
||||
expect(printName.getInfinity()).to.equal(Infinity)
|
||||
expect(printName.echo(Infinity)).to.equal(Infinity)
|
||||
})
|
||||
|
||||
it('keeps its constructor name for objects', () => {
|
||||
|
|
2
spec/fixtures/module/preload-sandbox.js
vendored
2
spec/fixtures/module/preload-sandbox.js
vendored
|
@ -28,7 +28,7 @@
|
|||
creationTime: invoke(() => process.getCreationTime()),
|
||||
heapStatistics: invoke(() => process.getHeapStatistics()),
|
||||
blinkMemoryInfo: invoke(() => process.getBlinkMemoryInfo()),
|
||||
processMemoryInfo: invoke(() => process.getProcessMemoryInfo()),
|
||||
processMemoryInfo: invoke(() => process.getProcessMemoryInfo() ? {} : null),
|
||||
systemMemoryInfo: invoke(() => process.getSystemMemoryInfo()),
|
||||
systemVersion: invoke(() => process.getSystemVersion()),
|
||||
cpuUsage: invoke(() => process.getCPUUsage()),
|
||||
|
|
|
@ -19,7 +19,7 @@
|
|||
SendZoomLevel().then(() => {
|
||||
if (!finalNavigation) {
|
||||
finalNavigation = true
|
||||
view.executeJavaScript('window.location.hash=123', () => {})
|
||||
view.executeJavaScript('window.location.hash=123')
|
||||
}
|
||||
})
|
||||
})
|
||||
|
|
|
@ -1068,7 +1068,7 @@ describe('<webview> tag', function () {
|
|||
await loadWebView(webview, { src })
|
||||
|
||||
const data = await webview.printToPDF({})
|
||||
expect(data).to.be.an.instanceof(Buffer).that.is.not.empty()
|
||||
expect(data).to.be.an.instanceof(Uint8Array).that.is.not.empty()
|
||||
})
|
||||
})
|
||||
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue