fix: child window with nativeWindowOpen should disable node integration (#15213)

* fix: child window with nativeWindowOpen should disable node integration

* Revert "fix: do not enable node integration in child window if not enabled (#15076)"

This reverts commit 0252d7686c.

This patch is not needed anymore since we are force disabling node integration
for child windows.
This commit is contained in:
Cheng Zhao 2018-10-25 15:31:07 +09:00 committed by GitHub
parent 7a23980f4b
commit 2f3a8ecd42
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
8 changed files with 36 additions and 55 deletions

View file

@ -1997,6 +1997,16 @@ describe('BrowserWindow module', () => {
w.loadFile(path.join(fixtures, 'api', 'window-open-location-open.html'))
})
})
it('should have nodeIntegration disabled in child windows', async () => {
return new Promise((resolve, reject) => {
ipcMain.once('answer', (event, typeofProcess) => {
assert.strictEqual(typeofProcess, 'undefined')
resolve()
})
w.loadFile(path.join(fixtures, 'api', 'native-window-open-argv.html'))
})
})
})
})