mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

fix: segfault when moving WebContentsView between BrowserWindows (#44613)

Browse source 
* fix: segfault when moving WebContentsView between BrowserWindows

Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>

* chore: actually enable fix

Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>

* fixup segfault when moving WebContentsView between BrowserWindows

Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>

---------

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
This commit is contained in:
trop[bot] 2024-11-11 22:09:29 -05:00 • committed by GitHub
parent c9d026e19b
commit 2f20dbea55
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 58 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

31
spec/fixtures/crash-cases/webview-move-between-windows/index.js vendored Normal file
View file

@ -0,0 +1,31 @@
const { app, BrowserWindow, WebContentsView } = require('electron');
function createWindow () {
// Create the browser window.
const mainWindow = new BrowserWindow();
const secondaryWindow = new BrowserWindow();
const contentsView = new WebContentsView();
mainWindow.contentView.addChildView(contentsView);
mainWindow.webContents.setDevToolsWebContents(contentsView.webContents);
mainWindow.openDevTools();
contentsView.setBounds({
x: 400,
y: 0,
width: 400,
height: 600
});
setTimeout(() => {
secondaryWindow.contentView.addChildView(contentsView);
setTimeout(() => {
mainWindow.contentView.addChildView(contentsView);
app.quit();
}, 1000);
}, 1000);
}
app.whenReady().then(() => {
createWindow();
});