diff --git a/atom/browser/atom_browser_main_parts_mac.mm b/atom/browser/atom_browser_main_parts_mac.mm index d6e83fd968b0..1bb3b1dc5876 100644 --- a/atom/browser/atom_browser_main_parts_mac.mm +++ b/atom/browser/atom_browser_main_parts_mac.mm @@ -18,7 +18,7 @@ void AtomBrowserMainParts::PreMainMessageLoopStart() { // Set our own application delegate. AtomApplicationDelegate* delegate = [[AtomApplicationDelegate alloc] init]; - [NSApp setDelegate:(id)delegate]; + [NSApp setDelegate:delegate]; brightray::BrowserMainParts::PreMainMessageLoopStart(); diff --git a/toolchain.gypi b/toolchain.gypi index 1c5f8a713518..754a1badac85 100644 --- a/toolchain.gypi +++ b/toolchain.gypi @@ -5,6 +5,10 @@ # Set this to true when building with Clang. 'clang%': 1, + 'clang_warning_flags': [ + '-Wno-undefined-var-template', # https://crbug.com/604888 + ], + 'variables': { # The minimum macOS SDK version to use. 'mac_sdk_min%': '10.10', @@ -104,6 +108,7 @@ 'cflags_cc': [ '-std=c++11', ], + 'cflags': [ '<@(clang_warning_flags)' ], 'xcode_settings': { 'CC': '<(make_clang_dir)/bin/clang', 'LDPLUSPLUS': '<(make_clang_dir)/bin/clang++', @@ -111,6 +116,7 @@ '-fcolor-diagnostics', ], + 'WARNING_CFLAGS': ['<@(clang_warning_flags)'], 'GCC_C_LANGUAGE_STANDARD': 'c99', # -std=c99 'CLANG_CXX_LIBRARY': 'libc++', # -stdlib=libc++ 'CLANG_CXX_LANGUAGE_STANDARD': 'c++11', # -std=c++11