mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge pull request #11254 from electron/fix-11246

Browse source 
Enable crashReporter module tests
This commit is contained in:
John Kleinschmidt 2017-11-30 12:55:49 -05:00 committed by GitHub
commit 2d75eea82a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 16 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

24
spec/api-crash-reporter-spec.js
View file

@ -52,14 +52,12 @@ describe('crashReporter module', () => {
} }
}) })
// TODO(alexeykuzmin): Disabled during Chromium 61 upgrade. it('should send minidump when renderer crashes', function (done) {
// It times out on Linux. Fix it and enable.
xit('should send minidump when renderer crashes', function (done) {
// TODO(alexeykuzmin): Skip the test instead of marking it as passed. // TODO(alexeykuzmin): Skip the test instead of marking it as passed.
if (process.env.APPVEYOR === 'True') return done() if (process.env.APPVEYOR === 'True') return done()
if (process.env.TRAVIS === 'true') return done() if (process.env.TRAVIS === 'true') return done()
this.timeout(120000) this.timeout(180000)
stopServer = startServer({ stopServer = startServer({
callback (port) { callback (port) {
@ -75,14 +73,12 @@ describe('crashReporter module', () => {
}) })
}) })
// TODO(alexeykuzmin): Disabled during Chromium 61 upgrade. it('should send minidump when node processes crash', function (done) {
// It times out on Linux. Fix it and enable.
xit('should send minidump when node processes crash', function (done) {
// TODO(alexeykuzmin): Skip the test instead of marking it as passed. // TODO(alexeykuzmin): Skip the test instead of marking it as passed.
if (process.env.APPVEYOR === 'True') return done() if (process.env.APPVEYOR === 'True') return done()
if (process.env.TRAVIS === 'true') return done() if (process.env.TRAVIS === 'true') return done()
this.timeout(120000) this.timeout(180000)
stopServer = startServer({ stopServer = startServer({
callback (port) { callback (port) {
@ -111,10 +107,8 @@ describe('crashReporter module', () => {
}) })
}) })
// TODO(alexeykuzmin): Disabled during Chromium 61 upgrade. it('should not send minidump if uploadToServer is false', function (done) {
// Fix it and enable. this.timeout(180000)
xit('should not send minidump if uploadToServer is false', function (done) {
this.timeout(120000)
let dumpFile let dumpFile
let crashesDir = crashReporter.getCrashesDirectory() let crashesDir = crashReporter.getCrashesDirectory()
@ -175,14 +169,12 @@ describe('crashReporter module', () => {
}) })
}) })
// TODO(alexeykuzmin): Disabled during Chromium 61 upgrade. it('should send minidump with updated extra parameters', function (done) {
// It times out on Linux. Fix it and enable.
xit('should send minidump with updated extra parameters', function (done) {
// TODO(alexeykuzmin): Skip the test instead of marking it as passed. // TODO(alexeykuzmin): Skip the test instead of marking it as passed.
if (process.env.APPVEYOR === 'True') return done() if (process.env.APPVEYOR === 'True') return done()
if (process.env.TRAVIS === 'true') return done() if (process.env.TRAVIS === 'true') return done()
this.timeout(120000) this.timeout(180000)
stopServer = startServer({ stopServer = startServer({
callback (port) { callback (port) {