mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

Fix creating window in <webview>

Browse source
This commit is contained in:
Cheng Zhao 2014-10-24 22:14:12 +08:00
parent a96cde254b
commit 2d56067819
1 changed files with 8 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
atom/browser/api/atom_api_web_contents.cc
View file

@ -170,7 +170,14 @@ void WebContents::WillAttach(content::WebContents* embedder_web_contents,
content::WebContents* WebContents::CreateNewGuestWindow( content::WebContents* WebContents::CreateNewGuestWindow(
const content::WebContents::CreateParams& create_params) { const content::WebContents::CreateParams& create_params) {
return nullptr; auto web_contents = content::WebContents::Create(create_params);
// TODO Currently we just retain the web_contents on V8's heap, which will be
// garbage collected later, we should provide a way to let users make use of
// this WebContents.
mate::Handle<WebContents> managed = CreateFrom(
v8::Isolate::GetCurrent(), web_contents);
managed->storage_.reset(web_contents);
return web_contents;
} }
void WebContents::DidAttach() { void WebContents::DidAttach() {