From 15bfb86eecd24267c2a47497878d2eb1332c628f Mon Sep 17 00:00:00 2001 From: John Kleinschmidt Date: Wed, 4 Oct 2017 11:35:41 -0400 Subject: [PATCH] Make sure test closes window Newly added test was leaving window open causing tests to fail --- spec/api-browser-window-spec.js | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/spec/api-browser-window-spec.js b/spec/api-browser-window-spec.js index 5aa2e97afe19..6cb668206d47 100644 --- a/spec/api-browser-window-spec.js +++ b/spec/api-browser-window-spec.js @@ -709,15 +709,16 @@ describe('BrowserWindow module', function () { }) }) - describe('BrowserWindow.addTabbedWindow()', function () { + describe('BrowserWindow.addTabbedWindow()', function (done) { it('does not throw', function () { if (process.platform !== 'darwin') { return } - + const tabbedWindow = new BrowserWindow({}) assert.doesNotThrow(() => { - w.addTabbedWindow(new BrowserWindow({})) + w.addTabbedWindow(tabbedWindow) }) + closeWindow(tabbedWindow).then(done) }) })