Merge pull request #4233 from atom/update-node

Ignore errors happened in Node's stdout/stdin stream
This commit is contained in:
Cheng Zhao 2016-01-26 20:50:23 +08:00
commit 2c7717d98e
3 changed files with 17 additions and 7 deletions

View file

@ -190,17 +190,24 @@ describe('node feature', function() {
return assert.equal(Buffer.byteLength(p.innerText), 13); return assert.equal(Buffer.byteLength(p.innerText), 13);
}); });
}); });
describe('process.stdout', function() { describe('process.stdout', function() {
it('should not throw exception', function() { it('should not throw exception', function() {
return process.stdout; process.stdout;
}); });
return xit('should have isTTY defined', function() {
return assert.equal(typeof process.stdout.isTTY, 'boolean'); it('should not throw exception when calling write()', function() {
process.stdout.write('test');
});
xit('should have isTTY defined', function() {
assert.equal(typeof process.stdout.isTTY, 'boolean');
}); });
}); });
return describe('vm.createContext', function() {
return it('should not crash', function() { describe('vm.createContext', function() {
return require('vm').runInNewContext(''); it('should not crash', function() {
require('vm').runInNewContext('');
}); });
}); });
}); });

View file

@ -28,6 +28,9 @@ app.commandLine.appendSwitch('disable-renderer-backgrounding');
// sure we can reproduce it in renderer process. // sure we can reproduce it in renderer process.
process.stdout; process.stdout;
// Access console to reproduce #3482.
console;
ipcMain.on('message', function(event, arg) { ipcMain.on('message', function(event, arg) {
event.sender.send('message', arg); event.sender.send('message', arg);
}); });

2
vendor/node vendored

@ -1 +1 @@
Subproject commit 3b044608ee51ca001dabe944cade6e64f46b0724 Subproject commit a130651f868f5ad23cb366abacea02f9ed50b769