mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

feat: add label property to Display objects (#36855)

Browse source
This commit is contained in:
Milan Burda 2023-01-18 07:44:40 +01:00 • committed by GitHub
parent a7bc579220
commit 2c56a06ad3
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 3 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

1
docs/api/structures/display.md
View file

@ -1,6 +1,7 @@
# Display Object
* `id` number - Unique identifier associated with the display.
* `label` string - User-friendly label, determined by the platform.
* `rotation` number - Can be 0, 90, 180, 270, represents screen rotation in
clock-wise degrees.
* `scaleFactor` number - Output device's pixel scale factor.

1
shell/common/gin_converters/gfx_converter.cc
View file

@ -144,6 +144,7 @@ v8::Local<v8::Value> Converter<display::Display>::ToV8(
gin_helper::Dictionary dict = gin::Dictionary::CreateEmpty(isolate);
dict.SetHidden("simple", true);
dict.Set("id", val.id());
dict.Set("label", val.label());
dict.Set("bounds", val.bounds());
dict.Set("workArea", val.work_area());
dict.Set("accelerometerSupport", val.accelerometer_support());

1
spec/api-screen-spec.ts
View file

@ -34,6 +34,7 @@ describe('screen module', () => {
expect(display).to.have.property('scaleFactor').that.is.a('number');
expect(display).to.have.property('id').that.is.a('number');
expect(display).to.have.property('label').that.is.a('string');
expect(display).to.have.property('rotation').that.is.a('number');
expect(display).to.have.property('touchSupport').that.is.a('string');
expect(display).to.have.property('accelerometerSupport').that.is.a('string');