From 2bf740d2fe0daed2ea6ef1f449f267a4bfb212db Mon Sep 17 00:00:00 2001 From: Samuel Attard Date: Thu, 21 Mar 2019 19:53:33 -0700 Subject: [PATCH] fix: remove enable_data_url_support from OnNetworkServiceCreated data URLs are _always_ enabled in the network service now and this is enforced in the Content layer. Refs: https://chromium-review.googlesource.com/c/chromium/src/+/1512337 --- atom/browser/net/system_network_context_manager.cc | 3 --- 1 file changed, 3 deletions(-) diff --git a/atom/browser/net/system_network_context_manager.cc b/atom/browser/net/system_network_context_manager.cc index f9d1a1267932..eac424117fcc 100644 --- a/atom/browser/net/system_network_context_manager.cc +++ b/atom/browser/net/system_network_context_manager.cc @@ -249,9 +249,6 @@ SystemNetworkContextManager::CreateNetworkContextParams() { network_context_params->http_cache_enabled = false; - // These are needed for PAC scripts that use file or data URLs (Or FTP URLs?). - // TODO(crbug.com/839566): remove file support for all cases. - network_context_params->enable_data_url_support = true; if (!base::FeatureList::IsEnabled(network::features::kNetworkService)) network_context_params->enable_file_url_support = true; #if !BUILDFLAG(DISABLE_FTP_SUPPORT)