mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

remove asserts that were obviated by dotenv

Browse source
This commit is contained in:
Zeke Sikelianos 2018-07-11 13:56:40 -07:00
parent 4f9b8d5d5a
commit 2bb970b98e
3 changed files with 0 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

3
script/ci-release-build.js
View file

@ -46,7 +46,6 @@ async function makeRequest (requestOptions, parseResponse) {
} }
async function circleCIcall (buildUrl, targetBranch, job, options) { async function circleCIcall (buildUrl, targetBranch, job, options) {
assert(process.env.CIRCLE_TOKEN, 'CIRCLE_TOKEN not found in environment')
console.log(`Triggering CircleCI to run build job: ${job} on branch: ${targetBranch} with release flag.`) console.log(`Triggering CircleCI to run build job: ${job} on branch: ${targetBranch} with release flag.`)
let buildRequest = { let buildRequest = {
'build_parameters': { 'build_parameters': {
@ -79,7 +78,6 @@ async function circleCIcall (buildUrl, targetBranch, job, options) {
} }
function buildAppVeyor (targetBranch, options) { function buildAppVeyor (targetBranch, options) {
assert(process.env.APPVEYOR_TOKEN, 'APPVEYOR_TOKEN not found in environment')
const validJobs = Object.keys(appVeyorJobs) const validJobs = Object.keys(appVeyorJobs)
if (options.job) { if (options.job) {
assert(validJobs.includes(options.job), `Unknown AppVeyor CI job name: ${options.job}. Valid values are: ${validJobs}.`) assert(validJobs.includes(options.job), `Unknown AppVeyor CI job name: ${options.job}. Valid values are: ${validJobs}.`)
@ -141,7 +139,6 @@ async function buildVSTS (targetBranch, options) {
assert(vstsJobs.includes(options.job), `Unknown VSTS CI job name: ${options.job}. Valid values are: ${vstsJobs}.`) assert(vstsJobs.includes(options.job), `Unknown VSTS CI job name: ${options.job}. Valid values are: ${vstsJobs}.`)
} }
console.log(`Triggering VSTS to run build on branch: ${targetBranch} with release flag.`) console.log(`Triggering VSTS to run build on branch: ${targetBranch} with release flag.`)
assert(process.env.VSTS_TOKEN, 'VSTS_TOKEN not found in environment')
let environmentVariables = {} let environmentVariables = {}
if (!options.ghRelease) { if (!options.ghRelease) {

2
script/prepare-release.js
View file

@ -5,7 +5,6 @@ require('colors')
const args = require('minimist')(process.argv.slice(2), { const args = require('minimist')(process.argv.slice(2), {
boolean: ['automaticRelease', 'notesOnly', 'stable'] boolean: ['automaticRelease', 'notesOnly', 'stable']
}) })
const assert = require('assert')
const ciReleaseBuild = require('./ci-release-build') const ciReleaseBuild = require('./ci-release-build')
const { execSync } = require('child_process') const { execSync } = require('child_process')
const fail = '\u2717'.red const fail = '\u2717'.red
@ -20,7 +19,6 @@ const versionType = args._[0]
// TODO (future) automatically determine version based on conventional commits // TODO (future) automatically determine version based on conventional commits
// via conventional-recommended-bump // via conventional-recommended-bump
assert(process.env.ELECTRON_GITHUB_TOKEN, 'ELECTRON_GITHUB_TOKEN not found in environment')
if (!versionType && !args.notesOnly) { if (!versionType && !args.notesOnly) {
console.log(`Usage: prepare-release versionType [major | minor | patch | beta]` + console.log(`Usage: prepare-release versionType [major | minor | patch | beta]` +
` (--stable) (--notesOnly) (--automaticRelease) (--branch)`) ` (--stable) (--notesOnly) (--automaticRelease) (--branch)`)

3
script/release.js
View file

@ -3,7 +3,6 @@
require('dotenv-safe').load() require('dotenv-safe').load()
require('colors') require('colors')
const args = require('minimist')(process.argv.slice(2)) const args = require('minimist')(process.argv.slice(2))
const assert = require('assert')
const fs = require('fs') const fs = require('fs')
const { execSync } = require('child_process') const { execSync } = require('child_process')
const GitHub = require('github') const GitHub = require('github')
@ -19,8 +18,6 @@ const temp = require('temp').track()
const { URL } = require('url') const { URL } = require('url')
let failureCount = 0 let failureCount = 0
assert(process.env.ELECTRON_GITHUB_TOKEN, 'ELECTRON_GITHUB_TOKEN not found in environment')
const github = new GitHub({ const github = new GitHub({
followRedirects: false followRedirects: false
}) })