mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

refactor: run clang-tidy (#20231)

Browse source 
* refactor: clang-tidy modernize-use-nullptr

* refactor: clang-tidy modernize-use-equals-default

* refactor: clang-tidy modernize-make-unique

* refactor: omit nullptr arg from unique_ptr.reset()

As per comment by @miniak
This commit is contained in:
Charles Kerr 2019-09-16 18:12:00 -04:00 • committed by GitHub
parent 660e566201
commit 2b316f3843
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
93 changed files with 261 additions and 223 deletions
Download patch file Download diff file Expand all files Collapse all files

8
shell/renderer/api/atom_api_spell_check_client.cc
View file

@ -5,6 +5,8 @@
#include "shell/renderer/api/atom_api_spell_check_client.h"
#include <map>
#include <memory>
#include <set>
#include <unordered_set>
#include <utility>
@ -55,7 +57,7 @@ class SpellCheckClient::SpellcheckRequest {
const base::string16& text,
std::unique_ptr<blink::WebTextCheckingCompletion> completion)
: text_(text), completion_(std::move(completion)) {}
~SpellcheckRequest() {}
~SpellcheckRequest() = default;
const base::string16& text() const { return text_; }
blink::WebTextCheckingCompletion* completion() { return completion_.get(); }
@ -105,8 +107,8 @@ void SpellCheckClient::RequestCheckingOfText(
pending_request_param_->completion()->DidCancelCheckingText();
}
pending_request_param_.reset(
new SpellcheckRequest(text, std::move(completionCallback)));
pending_request_param_ =
std::make_unique<SpellcheckRequest>(text, std::move(completionCallback));
base::ThreadTaskRunnerHandle::Get()->PostTask(
FROM_HERE,