mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

chore: remove unused internal env.unSetVar() (#43175)

Browse source 
chore: remove unused unSetVar JS binding

Added in Oct 2020 (b33f2260, #25623) but never used

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
This commit is contained in:
trop[bot] 2024-08-01 21:32:17 -05:00 committed by GitHub
parent f3fc1e626d
commit 2ad5d1ff71
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 0 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
shell/common/api/electron_api_environment.cc
View file

@ -25,10 +25,6 @@ bool SetVar(const std::string& name, const std::string& value) {
return base::Environment::Create()->SetVar(name, value);
}
bool UnSetVar(const std::string& name) {
return base::Environment::Create()->UnSetVar(name);
}
void Initialize(v8::Local<v8::Object> exports,
v8::Local<v8::Value> unused,
v8::Local<v8::Context> context,
@ -37,7 +33,6 @@ void Initialize(v8::Local<v8::Object> exports,
dict.SetMethod("getVar", &GetVar);
dict.SetMethod("hasVar", &HasVar);
dict.SetMethod("setVar", &SetVar);
dict.SetMethod("unSetVar", &UnSetVar);
}
} // namespace

1
typings/internal-ambient.d.ts vendored
View file

@ -52,7 +52,6 @@ declare namespace NodeJS {
getVar(name: string): string | null;
hasVar(name: string): boolean;
setVar(name: string, value: string): boolean;
unSetVar(name: string): boolean;
}
type AsarFileInfo = {