test: remove some remote usage from chromium specs (#20121)
* test: remove remote usage from chromium specs * disable tts test * port navigator.mediaDevices tests * fake camera and microphone * Update spec-main/chromium-spec.ts Co-Authored-By: John Kleinschmidt <jkleinsc@github.com>
This commit is contained in:
Jeremy Apthorp
GitHub
parent
1b2c6a33b3
commit
2aa7ab821c
5 changed files with 420 additions and 462 deletions
|
|
@ -1,15 +1,18 @@
|
|||
import * as chai from 'chai'
|
||||
import { expect } from 'chai'
|
||||
import * as chaiAsPromised from 'chai-as-promised'
|
||||
import { BrowserWindow, WebContents, session, ipcMain } from 'electron'
|
||||
import { emittedOnce } from './events-helpers';
|
||||
import { closeAllWindows } from './window-helpers';
|
||||
import * as https from 'https';
|
||||
import * as http from 'http';
|
||||
import * as path from 'path';
|
||||
import * as fs from 'fs';
|
||||
import { EventEmitter } from 'events';
|
||||
import { BrowserWindow, WebContents, session, ipcMain, app } from 'electron'
|
||||
import { emittedOnce } from './events-helpers'
|
||||
import { closeAllWindows } from './window-helpers'
|
||||
import * as https from 'https'
|
||||
import * as http from 'http'
|
||||
import * as path from 'path'
|
||||
import * as fs from 'fs'
|
||||
import * as url from 'url'
|
||||
import * as ChildProcess from 'child_process'
|
||||
import { EventEmitter } from 'events'
|
||||
|
||||
const { expect } = chai
|
||||
const features = process.electronBinding('features')
|
||||
|
||||
chai.use(chaiAsPromised)
|
||||
const fixturesPath = path.resolve(__dirname, '..', 'spec', 'fixtures')
|
||||
|
|
@ -242,3 +245,391 @@ describe('web security', () => {
|
|||
await p
|
||||
})
|
||||
})
|
||||
|
||||
describe('command line switches', () => {
|
||||
describe('--lang switch', () => {
|
||||
const currentLocale = app.getLocale()
|
||||
const testLocale = (locale: string, result: string, done: () => void) => {
|
||||
const appPath = path.join(fixturesPath, 'api', 'locale-check')
|
||||
const electronPath = process.execPath
|
||||
let output = ''
|
||||
const appProcess = ChildProcess.spawn(electronPath, [appPath, `--lang=${locale}`])
|
||||
|
||||
appProcess.stdout.on('data', (data) => { output += data })
|
||||
appProcess.stdout.on('end', () => {
|
||||
output = output.replace(/(\r\n|\n|\r)/gm, '')
|
||||
expect(output).to.equal(result)
|
||||
done()
|
||||
})
|
||||
}
|
||||
|
||||
it('should set the locale', (done) => testLocale('fr', 'fr', done))
|
||||
it('should not set an invalid locale', (done) => testLocale('asdfkl', currentLocale, done))
|
||||
})
|
||||
|
||||
describe('--remote-debugging-port switch', () => {
|
||||
it('should display the discovery page', (done) => {
|
||||
const electronPath = process.execPath
|
||||
let output = ''
|
||||
const appProcess = ChildProcess.spawn(electronPath, [`--remote-debugging-port=`])
|
||||
|
||||
appProcess.stderr.on('data', (data) => {
|
||||
output += data
|
||||
const m = /DevTools listening on ws:\/\/127.0.0.1:(\d+)\//.exec(output)
|
||||
if (m) {
|
||||
appProcess.stderr.removeAllListeners('data')
|
||||
const port = m[1]
|
||||
http.get(`http://127.0.0.1:${port}`, (res) => {
|
||||
res.destroy()
|
||||
appProcess.kill()
|
||||
expect(res.statusCode).to.eql(200)
|
||||
expect(parseInt(res.headers['content-length']!)).to.be.greaterThan(0)
|
||||
done()
|
||||
})
|
||||
}
|
||||
})
|
||||
})
|
||||
})
|
||||
})
|
||||
|
||||
describe('chromium features', () => {
|
||||
afterEach(closeAllWindows)
|
||||
|
||||
describe('accessing key names also used as Node.js module names', () => {
|
||||
it('does not crash', (done) => {
|
||||
const w = new BrowserWindow({ show: false })
|
||||
w.webContents.once('did-finish-load', () => { done() })
|
||||
w.webContents.once('crashed', () => done(new Error('WebContents crashed.')))
|
||||
w.loadFile(path.join(fixturesPath, 'pages', 'external-string.html'))
|
||||
})
|
||||
})
|
||||
|
||||
describe('loading jquery', () => {
|
||||
it('does not crash', (done) => {
|
||||
const w = new BrowserWindow({ show: false })
|
||||
w.webContents.once('did-finish-load', () => { done() })
|
||||
w.webContents.once('crashed', () => done(new Error('WebContents crashed.')))
|
||||
w.loadFile(path.join(fixturesPath, 'pages', 'jquery.html'))
|
||||
})
|
||||
})
|
||||
|
||||
describe('navigator.languages', () => {
|
||||
it('should return the system locale only', async () => {
|
||||
const appLocale = app.getLocale()
|
||||
const w = new BrowserWindow({ show: false })
|
||||
await w.loadURL('about:blank')
|
||||
const languages = await w.webContents.executeJavaScript(`navigator.languages`)
|
||||
expect(languages).to.deep.equal([appLocale])
|
||||
})
|
||||
})
|
||||
|
||||
describe('navigator.serviceWorker', () => {
|
||||
it('should register for file scheme', (done) => {
|
||||
const w = new BrowserWindow({
|
||||
show: false,
|
||||
webPreferences: {
|
||||
nodeIntegration: true,
|
||||
partition: 'sw-file-scheme-spec'
|
||||
}
|
||||
})
|
||||
w.webContents.on('ipc-message', (event, channel, message) => {
|
||||
if (channel === 'reload') {
|
||||
w.webContents.reload()
|
||||
} else if (channel === 'error') {
|
||||
done(message)
|
||||
} else if (channel === 'response') {
|
||||
expect(message).to.equal('Hello from serviceWorker!')
|
||||
session.fromPartition('sw-file-scheme-spec').clearStorageData({
|
||||
storages: ['serviceworkers']
|
||||
}).then(() => done())
|
||||
}
|
||||
})
|
||||
w.webContents.on('crashed', () => done(new Error('WebContents crashed.')))
|
||||
w.loadFile(path.join(fixturesPath, 'pages', 'service-worker', 'index.html'))
|
||||
})
|
||||
|
||||
it('should register for intercepted file scheme', (done) => {
|
||||
const customSession = session.fromPartition('intercept-file')
|
||||
customSession.protocol.interceptBufferProtocol('file', (request, callback) => {
|
||||
let file = url.parse(request.url).pathname!
|
||||
if (file[0] === '/' && process.platform === 'win32') file = file.slice(1)
|
||||
|
||||
const content = fs.readFileSync(path.normalize(file))
|
||||
const ext = path.extname(file)
|
||||
let type = 'text/html'
|
||||
|
||||
if (ext === '.js') type = 'application/javascript'
|
||||
callback({ data: content, mimeType: type } as any)
|
||||
}, (error) => {
|
||||
if (error) done(error)
|
||||
})
|
||||
|
||||
const w = new BrowserWindow({
|
||||
show: false,
|
||||
webPreferences: {
|
||||
nodeIntegration: true,
|
||||
session: customSession
|
||||
}
|
||||
})
|
||||
w.webContents.on('ipc-message', (event, channel, message) => {
|
||||
if (channel === 'reload') {
|
||||
w.webContents.reload()
|
||||
} else if (channel === 'error') {
|
||||
done(`unexpected error : ${message}`)
|
||||
} else if (channel === 'response') {
|
||||
expect(message).to.equal('Hello from serviceWorker!')
|
||||
customSession.clearStorageData({
|
||||
storages: ['serviceworkers']
|
||||
}).then(() => {
|
||||
customSession.protocol.uninterceptProtocol('file', error => done(error))
|
||||
})
|
||||
}
|
||||
})
|
||||
w.webContents.on('crashed', () => done(new Error('WebContents crashed.')))
|
||||
w.loadFile(path.join(fixturesPath, 'pages', 'service-worker', 'index.html'))
|
||||
})
|
||||
})
|
||||
|
||||
describe('navigator.geolocation', () => {
|
||||
before(function () {
|
||||
if (!features.isFakeLocationProviderEnabled()) {
|
||||
return this.skip()
|
||||
}
|
||||
})
|
||||
|
||||
it('returns error when permission is denied', (done) => {
|
||||
const w = new BrowserWindow({
|
||||
show: false,
|
||||
webPreferences: {
|
||||
nodeIntegration: true,
|
||||
partition: 'geolocation-spec'
|
||||
}
|
||||
})
|
||||
w.webContents.on('ipc-message', (event, channel) => {
|
||||
if (channel === 'success') {
|
||||
done()
|
||||
} else {
|
||||
done('unexpected response from geolocation api')
|
||||
}
|
||||
})
|
||||
w.webContents.session.setPermissionRequestHandler((wc, permission, callback) => {
|
||||
if (permission === 'geolocation') {
|
||||
callback(false)
|
||||
} else {
|
||||
callback(true)
|
||||
}
|
||||
})
|
||||
w.loadFile(path.join(fixturesPath, 'pages', 'geolocation', 'index.html'))
|
||||
})
|
||||
})
|
||||
|
||||
describe('window.open', () => {
|
||||
for (const show of [true, false]) {
|
||||
it(`inherits parent visibility over parent {show=${show}} option`, (done) => {
|
||||
const w = new BrowserWindow({ show })
|
||||
|
||||
// toggle visibility
|
||||
if (show) {
|
||||
w.hide()
|
||||
} else {
|
||||
w.show()
|
||||
}
|
||||
|
||||
w.webContents.once('new-window', (e, url, frameName, disposition, options) => {
|
||||
expect(options.show).to.equal(w.isVisible())
|
||||
w.close()
|
||||
done()
|
||||
})
|
||||
w.loadFile(path.join(fixturesPath, 'pages', 'window-open.html'))
|
||||
})
|
||||
}
|
||||
|
||||
it('disables node integration when it is disabled on the parent window for chrome devtools URLs', async () => {
|
||||
const w = new BrowserWindow({ show: false, webPreferences: { nodeIntegration: true } })
|
||||
w.loadURL('about:blank')
|
||||
w.webContents.executeJavaScript(`
|
||||
b = window.open('devtools://devtools/bundled/inspector.html', '', 'nodeIntegration=no,show=no')
|
||||
`)
|
||||
const [, contents] = await emittedOnce(app, 'web-contents-created')
|
||||
const typeofProcessGlobal = await contents.executeJavaScript('typeof process')
|
||||
expect(typeofProcessGlobal).to.equal('undefined')
|
||||
})
|
||||
|
||||
it('disables JavaScript when it is disabled on the parent window', async () => {
|
||||
const w = new BrowserWindow({ show: false, webPreferences: { nodeIntegration: true } })
|
||||
w.webContents.loadURL('about:blank')
|
||||
const windowUrl = require('url').format({
|
||||
pathname: `${fixturesPath}/pages/window-no-javascript.html`,
|
||||
protocol: 'file',
|
||||
slashes: true
|
||||
})
|
||||
w.webContents.executeJavaScript(`
|
||||
b = window.open(${JSON.stringify(windowUrl)}, '', 'javascript=no,show=no')
|
||||
`)
|
||||
const [, contents] = await emittedOnce(app, 'web-contents-created')
|
||||
await emittedOnce(contents, 'did-finish-load')
|
||||
// Click link on page
|
||||
contents.sendInputEvent({ type: 'mouseDown', clickCount: 1, x: 1, y: 1 })
|
||||
contents.sendInputEvent({ type: 'mouseUp', clickCount: 1, x: 1, y: 1 })
|
||||
const [, window] = await emittedOnce(app, 'browser-window-created')
|
||||
const preferences = (window.webContents as any).getLastWebPreferences()
|
||||
expect(preferences.javascript).to.be.false()
|
||||
})
|
||||
|
||||
it('handles cycles when merging the parent options into the child options', (done) => {
|
||||
const foo = {} as any
|
||||
foo.bar = foo
|
||||
foo.baz = {
|
||||
hello: {
|
||||
world: true
|
||||
}
|
||||
}
|
||||
foo.baz2 = foo.baz
|
||||
const w = new BrowserWindow({ show: false, foo: foo } as any)
|
||||
|
||||
w.loadFile(path.join(fixturesPath, 'pages', 'window-open.html'))
|
||||
w.webContents.once('new-window', (event, url, frameName, disposition, options) => {
|
||||
expect(options.show).to.be.false()
|
||||
expect((options as any).foo).to.deep.equal({
|
||||
bar: undefined,
|
||||
baz: {
|
||||
hello: {
|
||||
world: true
|
||||
}
|
||||
},
|
||||
baz2: {
|
||||
hello: {
|
||||
world: true
|
||||
}
|
||||
}
|
||||
})
|
||||
done()
|
||||
})
|
||||
})
|
||||
|
||||
it('defines a window.location getter', async () => {
|
||||
let targetURL: string
|
||||
if (process.platform === 'win32') {
|
||||
targetURL = `file:///${fixturesPath.replace(/\\/g, '/')}/pages/base-page.html`
|
||||
} else {
|
||||
targetURL = `file://${fixturesPath}/pages/base-page.html`
|
||||
}
|
||||
const w = new BrowserWindow({ show: false })
|
||||
w.loadURL('about:blank')
|
||||
w.webContents.executeJavaScript(`b = window.open(${JSON.stringify(targetURL)})`)
|
||||
const [, window] = await emittedOnce(app, 'browser-window-created')
|
||||
await emittedOnce(window.webContents, 'did-finish-load')
|
||||
expect(await w.webContents.executeJavaScript(`b.location.href`)).to.equal(targetURL)
|
||||
})
|
||||
|
||||
it('defines a window.location setter', async () => {
|
||||
const w = new BrowserWindow({ show: false })
|
||||
w.loadURL('about:blank')
|
||||
w.webContents.executeJavaScript(`b = window.open("about:blank")`)
|
||||
const [, { webContents }] = await emittedOnce(app, 'browser-window-created')
|
||||
await emittedOnce(webContents, 'did-finish-load')
|
||||
// When it loads, redirect
|
||||
w.webContents.executeJavaScript(`b.location = ${JSON.stringify(`file://${fixturesPath}/pages/base-page.html`)}`)
|
||||
await emittedOnce(webContents, 'did-finish-load')
|
||||
})
|
||||
|
||||
it('defines a window.location.href setter', async () => {
|
||||
const w = new BrowserWindow({ show: false })
|
||||
w.loadURL('about:blank')
|
||||
w.webContents.executeJavaScript(`b = window.open("about:blank")`)
|
||||
const [, { webContents }] = await emittedOnce(app, 'browser-window-created')
|
||||
await emittedOnce(webContents, 'did-finish-load')
|
||||
// When it loads, redirect
|
||||
w.webContents.executeJavaScript(`b.location.href = ${JSON.stringify(`file://${fixturesPath}/pages/base-page.html`)}`)
|
||||
await emittedOnce(webContents, 'did-finish-load')
|
||||
})
|
||||
|
||||
it('open a blank page when no URL is specified', async () => {
|
||||
const w = new BrowserWindow({ show: false })
|
||||
w.loadURL('about:blank')
|
||||
w.webContents.executeJavaScript(`b = window.open()`)
|
||||
const [, { webContents }] = await emittedOnce(app, 'browser-window-created')
|
||||
await emittedOnce(webContents, 'did-finish-load')
|
||||
expect(await w.webContents.executeJavaScript(`b.location.href`)).to.equal('about:blank')
|
||||
})
|
||||
|
||||
it('open a blank page when an empty URL is specified', async () => {
|
||||
const w = new BrowserWindow({ show: false })
|
||||
w.loadURL('about:blank')
|
||||
w.webContents.executeJavaScript(`b = window.open('')`)
|
||||
const [, { webContents }] = await emittedOnce(app, 'browser-window-created')
|
||||
await emittedOnce(webContents, 'did-finish-load')
|
||||
expect(await w.webContents.executeJavaScript(`b.location.href`)).to.equal('about:blank')
|
||||
})
|
||||
|
||||
it('sets the window title to the specified frameName', async () => {
|
||||
const w = new BrowserWindow({ show: false })
|
||||
w.loadURL('about:blank')
|
||||
w.webContents.executeJavaScript(`b = window.open('', 'hello')`)
|
||||
const [, window] = await emittedOnce(app, 'browser-window-created')
|
||||
expect(window.getTitle()).to.equal('hello')
|
||||
})
|
||||
|
||||
it('does not throw an exception when the frameName is a built-in object property', async () => {
|
||||
const w = new BrowserWindow({ show: false })
|
||||
w.loadURL('about:blank')
|
||||
w.webContents.executeJavaScript(`b = window.open('', '__proto__')`)
|
||||
const [, window] = await emittedOnce(app, 'browser-window-created')
|
||||
expect(window.getTitle()).to.equal('__proto__')
|
||||
})
|
||||
})
|
||||
|
||||
describe('window.opener', () => {
|
||||
it('is null for main window', async () => {
|
||||
const w = new BrowserWindow({
|
||||
show: false,
|
||||
webPreferences: {
|
||||
nodeIntegration: true
|
||||
}
|
||||
})
|
||||
w.loadFile(path.join(fixturesPath, 'pages', 'window-opener.html'))
|
||||
const [, channel, opener] = await emittedOnce(w.webContents, 'ipc-message')
|
||||
expect(channel).to.equal('opener')
|
||||
expect(opener).to.equal(null)
|
||||
})
|
||||
})
|
||||
|
||||
describe('navigator.mediaDevices', () => {
|
||||
afterEach(closeAllWindows)
|
||||
afterEach(() => {
|
||||
session.defaultSession.setPermissionCheckHandler(null)
|
||||
})
|
||||
|
||||
it('can return labels of enumerated devices', async () => {
|
||||
const w = new BrowserWindow({show: false})
|
||||
w.loadFile(path.join(fixturesPath, 'pages', 'blank.html'))
|
||||
const labels = await w.webContents.executeJavaScript(`navigator.mediaDevices.enumerateDevices().then(ds => ds.map(d => d.label))`)
|
||||
expect(labels.some((l: any) => l)).to.be.true()
|
||||
})
|
||||
|
||||
it('does not return labels of enumerated devices when permission denied', async () => {
|
||||
session.defaultSession.setPermissionCheckHandler(() => false)
|
||||
const w = new BrowserWindow({show: false})
|
||||
w.loadFile(path.join(fixturesPath, 'pages', 'blank.html'))
|
||||
const labels = await w.webContents.executeJavaScript(`navigator.mediaDevices.enumerateDevices().then(ds => ds.map(d => d.label))`)
|
||||
expect(labels.some((l: any) => l)).to.be.false()
|
||||
})
|
||||
|
||||
it('can return new device id when cookie storage is cleared', async () => {
|
||||
const ses = session.fromPartition('persist:media-device-id')
|
||||
const w = new BrowserWindow({
|
||||
show: false,
|
||||
webPreferences: {
|
||||
nodeIntegration: true,
|
||||
session: ses
|
||||
}
|
||||
})
|
||||
w.loadFile(path.join(fixturesPath, 'pages', 'media-id-reset.html'))
|
||||
const [, firstDeviceIds] = await emittedOnce(ipcMain, 'deviceIds')
|
||||
await ses.clearStorageData({ storages: ['cookies'] })
|
||||
w.webContents.reload()
|
||||
const [, secondDeviceIds] = await emittedOnce(ipcMain, 'deviceIds')
|
||||
expect(firstDeviceIds).to.not.deep.equal(secondDeviceIds)
|
||||
})
|
||||
})
|
||||
})
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue