mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

refactor: clean up unused parts of the render_frame_host patch file (#28769)

Browse source 
* chore: remove CanUseCustomSiteInstance

* chore: remove unused ShouldOverrideSiteInstanceForNavigation

* chore: remove CreateRelatedSiteInstance

* chore: remove BrowsingInstance::CreateSiteInstanceForURL

* chore: remove NavigationState::REUSE_SITE_INSTANCE

* chore: remove accidentally duplicated code post-patch-clean

* chore: reword patch description for new feature-set

* chore: remove ShouldForceNewSiteInstance and all its unused helpers
This commit is contained in:
Samuel Attard 2021-04-22 10:55:32 -07:00 • committed by GitHub
parent 43d27cc4d1
commit 28904714ae
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 5 additions and 458 deletions
Download patch file Download diff file Expand all files Collapse all files

21
shell/browser/electron_browser_client.h
View file

@ -85,7 +85,6 @@ class ElectronBrowserClient : public content::ContentBrowserClient,
void SetUserAgent(const std::string& user_agent);
content::SerialDelegate* GetSerialDelegate() override;
bool CanUseCustomSiteInstance() override;
content::BluetoothDelegate* GetBluetoothDelegate() override;
@ -97,14 +96,6 @@ class ElectronBrowserClient : public content::ContentBrowserClient,
void OverrideWebkitPrefs(content::WebContents* web_contents,
blink::web_pref::WebPreferences* prefs) override;
SiteInstanceForNavigationType ShouldOverrideSiteInstanceForNavigation(
content::RenderFrameHost* current_rfh,
content::RenderFrameHost* speculative_rfh,
content::BrowserContext* browser_context,
const GURL& url,
bool has_navigation_started,
bool has_response_started,
content::SiteInstance** affinity_site_instance) const override;
void RegisterPendingSiteInstance(
content::RenderFrameHost* render_frame_host,
content::SiteInstance* pending_site_instance) override;
@ -289,21 +280,9 @@ class ElectronBrowserClient : public content::ContentBrowserClient,
content::BrowserContext* browser_context = nullptr;
};
bool ShouldForceNewSiteInstance(content::RenderFrameHost* current_rfh,
content::RenderFrameHost* speculative_rfh,
content::BrowserContext* browser_context,
const GURL& dest_url,
bool has_response_started) const;
bool NavigationWasRedirectedCrossSite(
content::BrowserContext* browser_context,
content::SiteInstance* current_instance,
content::SiteInstance* speculative_instance,
const GURL& dest_url,
bool has_response_started) const;
void AddProcessPreferences(int process_id, ProcessPreferences prefs);
void RemoveProcessPreferences(int process_id);
bool IsProcessObserved(int process_id) const;
bool IsRendererSandboxed(int process_id) const;
bool RendererUsesNativeWindowOpen(int process_id) const;
bool RendererDisablesPopups(int process_id) const;
content::SiteInstance* GetSiteInstanceFromAffinity(