mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

feat: add exit code to render-process-gone details (#27580)

Browse source
This commit is contained in:
Jeremy Rose 2021-02-08 17:08:11 -08:00 committed by GitHub
parent fdd08f7934
commit 28599e5e7c
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 7 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
docs/api/app.md
View file

@ -406,6 +406,9 @@ Returns:
* `oom` - Process ran out of memory * `oom` - Process ran out of memory
* `launch-failed` - Process never successfully launched * `launch-failed` - Process never successfully launched
* `integrity-failure` - Windows code integrity checks failed * `integrity-failure` - Windows code integrity checks failed
* `exitCode` Integer - The exit code of the process, unless `reason` is
`launch-failed`, in which case `exitCode` will be a platform-specific
launch failure error code.
Emitted when the renderer process unexpectedly disappears. This is normally Emitted when the renderer process unexpectedly disappears. This is normally
because it was crashed or killed. because it was crashed or killed.

3
docs/api/web-contents.md
View file

@ -403,6 +403,9 @@ Returns:
* `oom` - Process ran out of memory * `oom` - Process ran out of memory
* `launch-failed` - Process never successfully launched * `launch-failed` - Process never successfully launched
* `integrity-failure` - Windows code integrity checks failed * `integrity-failure` - Windows code integrity checks failed
* `exitCode` Integer - The exit code of the process, unless `reason` is
`launch-failed`, in which case `exitCode` will be a platform-specific
launch failure error code.
Emitted when the renderer process unexpectedly disappears. This is normally Emitted when the renderer process unexpectedly disappears. This is normally
because it was crashed or killed. because it was crashed or killed.

1
shell/browser/api/electron_api_web_contents.cc
View file

@ -1396,6 +1396,7 @@ void WebContents::RenderProcessGone(base::TerminationStatus status) {
v8::HandleScope handle_scope(isolate); v8::HandleScope handle_scope(isolate);
gin_helper::Dictionary details = gin_helper::Dictionary::CreateEmpty(isolate); gin_helper::Dictionary details = gin_helper::Dictionary::CreateEmpty(isolate);
details.Set("reason", status); details.Set("reason", status);
details.Set("exitCode", web_contents()->GetCrashedErrorCode());
Emit("render-process-gone", details); Emit("render-process-gone", details);
} }