mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

refactor: use std::optional in MicrotasksScope (#43621)

Browse source 
avoid an unnecessary heap allocation/free
This commit is contained in:
Charles Kerr 2024-09-09 11:51:42 -05:00 • committed by GitHub
parent e2fe8f50e2
commit 2844e346b9
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 3 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

4
shell/common/gin_helper/microtasks_scope.h
View file

@ -5,7 +5,7 @@
#ifndef ELECTRON_SHELL_COMMON_GIN_HELPER_MICROTASKS_SCOPE_H_
#define ELECTRON_SHELL_COMMON_GIN_HELPER_MICROTASKS_SCOPE_H_
#include <memory>
#include <optional>
#include "v8/include/v8-forward.h"
#include "v8/include/v8-microtask-queue.h"
@ -27,7 +27,7 @@ class MicrotasksScope {
MicrotasksScope& operator=(const MicrotasksScope&) = delete;
private:
std::unique_ptr<v8::MicrotasksScope> v8_microtasks_scope_;
std::optional<v8::MicrotasksScope> v8_microtasks_scope_;
};
} // namespace gin_helper