mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

fix: WebContentsView removal should compare directly (#44656)

Browse source 
* fix: WebContentsView removal should compare directly

* fixup view comparision

* chore: use erase_if

* Apply review suggestions

---------

Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
This commit is contained in:
Shelley Vohr 2024-11-15 04:11:20 +01:00 • committed by GitHub
parent b1957f52e3
commit 27fe6cc97f
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 43 additions and 26 deletions
Download patch file Download diff file Expand all files Collapse all files

4
shell/browser/api/electron_api_view.h
View file

@ -21,6 +21,8 @@ class Handle;
namespace electron::api {
using ChildPair = std::pair<raw_ptr<views::View>, v8::Global<v8::Object>>;
class View : public gin_helper::EventEmitter<View>,
private views::ViewObserver {
public:
@ -69,7 +71,7 @@ class View : public gin_helper::EventEmitter<View>,
void ApplyBorderRadius();
void ReorderChildView(gin::Handle<View> child, size_t index);
std::vector<v8::Global<v8::Object>> child_views_;
std::vector<ChildPair> child_views_;
std::optional<int> border_radius_;
bool delete_view_ = true;