mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

fix: run visibleOnAllWorkspaces tests on the right platforms (#46815)

Browse source 
* test: add platform test on visibleOnAllWorkspaces tests

visibleOnAllWorkspaces is not supported on Windows

* test: do not skip visibleOnAllWorkspaces tests on Windows

That feature is supported on Linux, so move the test from the
"window states (excluding Linux)" section into the
"window states" section.

* fix: nested it() calls in visibleOnAllWorkspaces specs

* chore: make the process.platform test simpler
This commit is contained in:
Charles Kerr 2025-04-28 09:34:00 -05:00 • committed by GitHub
parent b03c71213e
commit 27f6adf8df
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 20 additions and 20 deletions
Download patch file Download diff file Expand all files Collapse all files

40
spec/api-browser-window-spec.ts
View file

@ -5407,6 +5407,26 @@ describe('BrowserWindow module', () => {
expect(w.webContents.isLoadingMainFrame()).to.be.true('isLoadingMainFrame'); expect(w.webContents.isLoadingMainFrame()).to.be.true('isLoadingMainFrame');
}); });
}); });
ifdescribe(process.platform !== 'win32')('visibleOnAllWorkspaces state', () => {
describe('with properties', () => {
it('can be changed', () => {
const w = new BrowserWindow({ show: false });
expect(w.visibleOnAllWorkspaces).to.be.false();
w.visibleOnAllWorkspaces = true;
expect(w.visibleOnAllWorkspaces).to.be.true();
});
});
describe('with functions', () => {
it('can be changed', () => {
const w = new BrowserWindow({ show: false });
expect(w.isVisibleOnAllWorkspaces()).to.be.false();
w.setVisibleOnAllWorkspaces(true);
expect(w.isVisibleOnAllWorkspaces()).to.be.true();
});
});
});
}); });
ifdescribe(process.platform !== 'linux')('window states (excluding Linux)', () => { ifdescribe(process.platform !== 'linux')('window states (excluding Linux)', () => {
@ -5447,26 +5467,6 @@ describe('BrowserWindow module', () => {
}); });
}); });
describe('visibleOnAllWorkspaces state', () => {
it('with properties', () => {
it('can be changed', () => {
const w = new BrowserWindow({ show: false });
expect(w.visibleOnAllWorkspaces).to.be.false();
w.visibleOnAllWorkspaces = true;
expect(w.visibleOnAllWorkspaces).to.be.true();
});
});
it('with functions', () => {
it('can be changed', () => {
const w = new BrowserWindow({ show: false });
expect(w.isVisibleOnAllWorkspaces()).to.be.false();
w.setVisibleOnAllWorkspaces(true);
expect(w.isVisibleOnAllWorkspaces()).to.be.true();
});
});
});
ifdescribe(process.platform === 'darwin')('documentEdited state', () => { ifdescribe(process.platform === 'darwin')('documentEdited state', () => {
it('with properties', () => { it('with properties', () => {
it('can be changed', () => { it('can be changed', () => {