From 27e68058896bf2589fc75ce1a9a6fe23b10b6b9d Mon Sep 17 00:00:00 2001 From: Jeremy Apthorp Date: Fri, 27 Jul 2018 08:05:36 -0700 Subject: [PATCH] build: [gn] pack ui_strings in locales (#13827) Fixes a crash when running the tests on linux: [15860:0726/132247.086106:WARNING:resource_bundle.cc(586)] unable to find resource: 27282 [15860:0726/132247.086189:FATAL:resource_bundle.cc(587)] Check failed: false. 0 0x7f1cad88ed7d base::debug::StackTrace::StackTrace() 1 0x7f1cad88eccc base::debug::StackTrace::StackTrace() 2 0x7f1cad9327ba logging::LogMessage::~LogMessage() 3 0x7f1ca4dea3ae ui::ResourceBundle::GetLocalizedString() 4 0x7f1ca4db5113 l10n_util::GetStringUTF16() 5 0x7f1ca3753bdd views::(anonymous namespace)::EmptyMenuMenuItem::EmptyMenuMenuItem() --- electron_paks.gni | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/electron_paks.gni b/electron_paks.gni index 470be81b9192..af3e218daf44 100644 --- a/electron_paks.gni +++ b/electron_paks.gni @@ -140,9 +140,13 @@ template("electron_paks") { repack_whitelist = invoker.repack_whitelist } - source_patterns = [ "${root_gen_dir}/content/app/strings/content_strings_" ] + source_patterns = [ + "${root_gen_dir}/content/app/strings/content_strings_", + "${root_gen_dir}/ui/strings/ui_strings_", + ] deps = [ "//content/app/strings", + "//ui/strings:ui_strings", ] input_locales = locales