mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

refactor: minor electron browser context cleanup (#42789)

Browse source 
* refactor: make DevicePermissionMap private to electron::ElectronBrowserContext

refactor: make PartitionPath private to electron::ElectronBrowserContext

* refactor: remove unused forward declarations of v8 classes

* chore: forward declare gin::Arguments

* refactor: use unique_ptr operator bool
This commit is contained in:
Charles Kerr 2024-07-08 09:49:41 -05:00 • committed by GitHub
parent e99e554655
commit 27e3273f0a
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 17 additions and 22 deletions
Download patch file Download diff file Expand all files Collapse all files

11
shell/browser/electron_browser_context.cc
View file

@ -467,7 +467,7 @@ bool ElectronBrowserContext::IsOffTheRecord() {
}
std::string ElectronBrowserContext::GetMediaDeviceIDSalt() {
if (!media_device_id_salt_.get())
if (!media_device_id_salt_)
media_device_id_salt_ = std::make_unique<MediaDeviceIDSalt>(prefs_.get());
return media_device_id_salt_->GetSalt();
}
@ -483,10 +483,9 @@ ElectronBrowserContext::CreateZoomLevelDelegate(
content::DownloadManagerDelegate*
ElectronBrowserContext::GetDownloadManagerDelegate() {
if (!download_manager_delegate_.get()) {
auto* download_manager = this->GetDownloadManager();
if (!download_manager_delegate_) {
download_manager_delegate_ =
std::make_unique<ElectronDownloadManagerDelegate>(download_manager);
std::make_unique<ElectronDownloadManagerDelegate>(GetDownloadManager());
}
return download_manager_delegate_.get();
}
@ -504,7 +503,7 @@ ElectronBrowserContext::GetPlatformNotificationService() {
content::PermissionControllerDelegate*
ElectronBrowserContext::GetPermissionControllerDelegate() {
if (!permission_manager_.get())
if (!permission_manager_)
permission_manager_ = std::make_unique<ElectronPermissionManager>();
return permission_manager_.get();
}
@ -519,7 +518,7 @@ std::string ElectronBrowserContext::GetUserAgent() const {
}
predictors::PreconnectManager* ElectronBrowserContext::GetPreconnectManager() {
if (!preconnect_manager_.get()) {
if (!preconnect_manager_) {
preconnect_manager_ =
std::make_unique<predictors::PreconnectManager>(nullptr, this);
}