mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

use will-create-webview event

Browse source
This commit is contained in:
Hari Juturu 2017-05-09 10:12:44 -07:00
parent a05eb9047e
commit 277c3155a6
2 changed files with 1 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

3
atom/browser/api/atom_api_web_contents.cc
View file

@ -406,9 +406,6 @@ void WebContents::InitWithSessionAndOptions(v8::Isolate* isolate,
Init(isolate); Init(isolate);
AttachAsUserData(web_contents); AttachAsUserData(web_contents);
if (IsGuest())
Emit("did-create-webview");
} }
WebContents::~WebContents() { WebContents::~WebContents() {

2
docs/api/browser-window.md
View file

@ -310,7 +310,7 @@ It creates a new `BrowserWindow` with native properties as set by the `options`.
* `overrideWebViewSecurity` Boolean (optional) - Whether to enable [webview-tag](webview-tag.md) * `overrideWebViewSecurity` Boolean (optional) - Whether to enable [webview-tag](webview-tag.md)
ignoring the security restriction based on `nodeIntegration`. Enabling this option will ignoring the security restriction based on `nodeIntegration`. Enabling this option will
have security implication on creating `webview` with `nodeIntegration` disabled. To avoid the have security implication on creating `webview` with `nodeIntegration` disabled. To avoid the
security risk, listen to `will-create-webview` event on [web-contents](web-contents.md) and security risk, listen to `will-attach-webview` event on [web-contents](web-contents.md) and
stop creating `webview` or removing preload scripts. stop creating `webview` or removing preload scripts.
When setting minimum or maximum window size with `minWidth`/`maxWidth`/ When setting minimum or maximum window size with `minWidth`/`maxWidth`/