mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

test: move some BrowserWindow specs to the main process (#19182)

Browse source 
* test: move some BrowserWindow specs to the main process

* uncomment cross-site test

* move more tests

* re-enable, refactor and move visibilitychange specs

* move new-window event tests and re-enable them on mac

* move max/minimize event tests

* move modal tests

* move beginFrameSubscription tests

* move savePage test

* move BrowserWindow options argument is optional test

* move restore, unmaximize, fullscreen tests

* move parent window tests

* don't wait for show event on windows (#8664)

* add debugging logs to fullscreen tests

* more debugging on windows

* explicitly destroy browserviews to prevent crash during gc

* only await show on darwin

* more event timing fixes

* disable max/minimize event tests on linux, since they're broken on CI
This commit is contained in:
Jeremy Apthorp 2019-07-15 21:13:32 -07:00 • committed by Shelley Vohr
parent 7249b25868
commit 27599a851f
7 changed files with 1474 additions and 1677 deletions
Download patch file Download diff file Expand all files Collapse all files

6
shell/browser/api/atom_api_system_preferences_mac.mm
View file

@ -218,14 +218,12 @@ int SystemPreferences::DoSubscribeNotification(
if (user_info) {
copied_callback.Run(
base::SysNSStringToUTF8(notification.name),
*user_info,
base::SysNSStringToUTF8(notification.name), *user_info,
object);
} else {
copied_callback.Run(
base::SysNSStringToUTF8(notification.name),
base::DictionaryValue(),
object);
base::DictionaryValue(), object);
}
}];
return request_id;