mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

fix: add handling for non-absolute extension paths (#25068)

Browse source
This commit is contained in:
Samuel Attard 2020-08-20 20:47:10 -07:00 committed by GitHub
parent 42409d860b
commit 26f28b6ae4
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
shell/browser/api/electron_api_session.cc
View file

@ -684,6 +684,13 @@ v8::Local<v8::Promise> Session::LoadExtension(
v8::Isolate* isolate = JavascriptEnvironment::GetIsolate(); v8::Isolate* isolate = JavascriptEnvironment::GetIsolate();
gin_helper::Promise<const extensions::Extension*> promise(isolate); gin_helper::Promise<const extensions::Extension*> promise(isolate);
v8::Local<v8::Promise> handle = promise.GetHandle(); v8::Local<v8::Promise> handle = promise.GetHandle();
if (!extension_path.IsAbsolute()) {
promise.RejectWithErrorMessage(
"The path to the extension in 'loadExtension' must be absolute");
return handle;
}
if (browser_context()->IsOffTheRecord()) { if (browser_context()->IsOffTheRecord()) {
promise.RejectWithErrorMessage( promise.RejectWithErrorMessage(
"Extensions cannot be loaded in a temporary session"); "Extensions cannot be loaded in a temporary session");