mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

test: remove a bunch of usage of the remote module (#21119)

Browse source
This commit is contained in:
Jeremy Apthorp 2019-11-14 14:09:03 -08:00 • committed by GitHub
parent 4f1536479e
commit 26ecf63ab4
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
22 changed files with 124 additions and 125 deletions
Download patch file Download diff file Expand all files Collapse all files

20
spec-main/api-remote-spec.ts
View file

@ -158,6 +158,24 @@ ifdescribe(features.isRemoteModuleEnabled())('remote module', () => {
})
})
describe('remote objects registry', () => {
it('does not dereference until the render view is deleted (regression)', (done) => {
const w = new BrowserWindow({
show: false,
webPreferences: {
nodeIntegration: true
}
})
ipcMain.once('error-message', (event, message) => {
expect(message).to.match(/^Cannot call method 'getURL' on missing remote object/)
done()
})
w.loadFile(path.join(fixtures, 'api', 'render-view-deleted.html'))
})
})
describe('remote listeners', () => {
afterEach(closeAllWindows)
@ -168,7 +186,7 @@ ifdescribe(features.isRemoteModuleEnabled())('remote module', () => {
nodeIntegration: true
}
})
await w.loadFile(path.join(__dirname, '..', 'spec', 'fixtures', 'api', 'remote-event-handler.html'))
await w.loadFile(path.join(fixtures, 'api', 'remote-event-handler.html'))
w.webContents.reload()
await emittedOnce(w.webContents, 'did-finish-load')